| *** marios is now known as marios|ruck | 05:38 | |
| *** jpena|off is now known as jpena | 07:00 | |
| *** frickler_pto is now known as frickler | 07:14 | |
| *** rpittau|afk is now known as rpittau | 07:15 | |
| frickler | ianw: from backlog I gather that you were waiting for me to return, but I'm not sure what I should do now | 07:22 |
|---|---|---|
| ianw | frickler: hey there; hope you had fun! the only thing was checking if you had anything on review01.openstack.org before i removed it | 07:47 |
| ianw | fungi/clarkb: re https://review.opendev.org/c/zuul/zuul-jobs/+/802981 that removes wheel setup on centos-8-stream. builds work @ https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802988 | 07:54 |
| ianw | I have added volumes to publish those; however i need some more work on the slug generation to make sure it generates the right volume name to release in the publish jobs. | 07:55 |
| ianw | unfortunately for volume-character length reasons its mirror.wheel.cent8s<x64|a64> which doesn't fit the simple template we have, and also current ansible doesn't pick up stream correctly in its facts | 07:56 |
| nurs | morning | 07:57 |
| *** gibi_pto is now known as gibi | 08:00 | |
| *** sshnaidm_ is now known as sshnaidm | 08:20 | |
| *** ykarel is now known as ykarel|lunch | 08:34 | |
| opendevreview | Andy Ladjadj proposed zuul/zuul-jobs master: [ensure-python] install python version only if not present https://review.opendev.org/c/zuul/zuul-jobs/+/770656 | 09:05 |
| opendevreview | Ananya proposed opendev/elastic-recheck master: Run elastic-recheck in container https://review.opendev.org/c/opendev/elastic-recheck/+/802866 | 09:08 |
| *** ykarel|lunch is now known as ykarel | 10:10 | |
| opendevreview | Kendall Nelson proposed opendev/system-config master: Setting Up Ansible For ptgbot https://review.opendev.org/c/opendev/system-config/+/803190 | 10:47 |
| *** jpena is now known as jpena|lunch | 11:30 | |
| opendevreview | Tristan Cacqueray proposed opendev/system-config master: Add gerritbot-matrix health check and expose prometheus monitoring https://review.opendev.org/c/opendev/system-config/+/803125 | 12:20 |
| *** jpena|lunch is now known as jpena | 12:28 | |
| opendevreview | Kendall Nelson proposed opendev/system-config master: Setting Up Ansible For ptgbot https://review.opendev.org/c/opendev/system-config/+/803190 | 12:30 |
| opendevreview | Tristan Cacqueray proposed opendev/system-config master: Add gerritbot-matrix health check and expose prometheus monitoring https://review.opendev.org/c/opendev/system-config/+/803125 | 13:07 |
| opendevreview | Ananya proposed opendev/elastic-recheck master: Run elastic-recheck in container https://review.opendev.org/c/opendev/elastic-recheck/+/802866 | 13:13 |
| fungi | ianw: the x64/a64 convention already came up because i had to shorten a volume name, so i don't have any objection with fitting whatever you can manage to disambiguate it from other platforms | 13:13 |
| fungi | it's a very tight length limit anyway, only so much we can do | 13:14 |
| diablo_rojo | clarkb, fungi would you mind giving this a look when you get a sec? https://review.opendev.org/c/opendev/system-config/+/797549 | 14:13 |
| *** ykarel is now known as ykarel|away | 14:16 | |
| fungi | diablo_rojo: thanks for the heads up, i didn't realize you'd pushed that | 14:22 |
| clarkb | looks like the review cert refreshed successfully over the weekend | 14:47 |
| clarkb | diablo_rojo: yup I can take a look. | 14:52 |
| clarkb | infra-root I'm also hoping to tackle the gerrit known hosts change and have it manage gitea known hosts as well. Basically make it mergeable and have it cover the known needed entries | 14:53 |
| clarkb | fungi: diablo_rojo: I +2'd that but didn't approve as I think this is our first new list addition after rewriting the list management. Is there anything else we should be checking before we land the change (this is primarily directed at fungi) | 14:55 |
| clarkb | if not maybe fungi you want to approve it when you are able to help monitor it go in (I should be able to watch it all day) | 14:55 |
| fungi | clarkb: it took a day or two for the script to stop complaining about the review cert after it renewed, so i expect there was (and might still be) one or more apache workers hanging onto the old one | 15:04 |
| clarkb | ah | 15:05 |
| fungi | but i agree we haven't had any more alerts about it in the past 24 hours | 15:05 |
| fungi | and yeah, i can't think of anything else we want to check on the list creation side of things, but i'm happy to monitor it and troubleshoot after the change deploys | 15:06 |
| fungi | approving now | 15:06 |
| fungi | clarkb: diablo_rojo: oh, actually i just spotted a problem with that change | 15:08 |
| fungi | see inline comment, i don't think the admin address is valid | 15:08 |
| fungi | diablo_rojo: if you have a minute to fix that up to what you want it to be, i'm happy to reapprove | 15:08 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve gerrit known_hosts management https://review.opendev.org/c/opendev/system-config/+/802922 | 15:21 |
| clarkb | That feels too easy, but maybe it is that simple to get gitea and gerrit known_host keys managed on review | 15:21 |
| clarkb | fungi: also if you get a chacne today can you take a look over the next set of proposed gerrit account cleanups? | 15:22 |
| fungi | yup | 15:23 |
| clarkb | I think this should be the second to the last batch with the last batch being fixed in a large commit to push back to gerrit | 15:23 |
| clarkb | thanks | 15:24 |
| *** jpena is now known as jpena|off | 15:25 | |
| clarkb | I'm also working on getting the merge rollups for ianw's mariadb and my openid fix in gerrit proposed/landed. I don't want to forget about that and have us udpate to fixed 3.2 then upgrade to 3.3 or 3.4 and regress | 15:40 |
| *** diablo_rojo is now known as Guest3074 | 16:08 | |
| corvus | i'm making the gerrit synapse user | 16:11 |
| corvus | tristanC, clarkb, mordred: when i create a user with EMS, it also supplies me with an access token (device id "-"). i guess we could use that? or would it be better to create a new device and get a new access token? | 16:13 |
| mordred | corvus: I'm not sure | 16:14 |
| clarkb | corvus: I'm ok using the default access token if that makes things easy. | 16:14 |
| corvus | clarkb: it is easier, but not by much (it's just a curl command to get a new device+token) | 16:15 |
| corvus | we're testing -- let's try out the default token and see what happens :) | 16:16 |
| clarkb | wfm | 16:16 |
| opendevreview | Kendall Nelson proposed opendev/system-config master: Add mailing list for FLOSS MOOC https://review.opendev.org/c/opendev/system-config/+/797549 | 16:18 |
| corvus | i don't see a way to get an access token through the ui after creating the account | 16:20 |
| corvus | so that's probably a one-time thing | 16:20 |
| *** rpittau is now known as rpittau|afk | 16:24 | |
| corvus | i added the matrix token and approved the matrix eavesdrop changes | 16:24 |
| *** sshnaidm is now known as sshnaidm|afk | 16:25 | |
| *** marios|ruck is now known as marios|out | 16:26 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: WIP Prepare gitea 1.15.0 upgrade https://review.opendev.org/c/opendev/system-config/+/803231 | 16:32 |
| clarkb | I noticed whe nwe did the 1.14 upgrades that there is a 1.15 release candidate. This is prep work to be ready for that release | 16:32 |
| opendevreview | Merged opendev/system-config master: Add matrix-eavesdrop container image https://review.opendev.org/c/opendev/system-config/+/800317 | 16:35 |
| clarkb | ha ok my known_hosts fixup change exposes a fun thing with our testing and prod deployment. If we use group vars in testing and host vars in prod all on the public side of things then the public host vars override the test specific group vars | 16:43 |
| clarkb | I think this has a relatively simple fix, move the prod stuff into a group var file from a host vars file. But something to be aware of I guess | 16:43 |
| corvus | clarkb: yeah, the intent is they should be the same | 16:45 |
| corvus | anything on bridge should be in a .j2 file in system-config | 16:45 |
| corvus | playbooks/zuul/templates/groupvars/gitea.yaml.j2 in system-config should have the same variables as /etc/ansible/hosts/groupvars/gitea.yaml on bridge | 16:47 |
| corvus | except with underscores :) | 16:47 |
| corvus | * `playbooks/zuul/templates/group_vars/gitea.yaml.j2` in system-config should have the same `variables as /etc/ansible/hosts/group_vars/gitea.yaml` on bridge | 16:47 |
| clarkb | ya it gets weird where we have publicly defined things that need to be different in each | 16:47 |
| clarkb | in this case the known_hosts keys are different sets because talking to the test node is different than the prod node | 16:49 |
| clarkb | I suspect this means we are also writing out a prod replication config in the test setup but then that fails as it doesn't have the right ssh keys to do anything with that | 16:49 |
| fungi | because of differences in secret data | 16:50 |
| clarkb | fungi: ya | 16:50 |
| fungi | i wonder if we should be stashing the "public" counterparts of the secrets with the secret data instead | 16:50 |
| corvus | fungi: yeah, i think that might be a good solution | 16:50 |
| corvus | you can't change the public key without changing the private one :) | 16:50 |
| fungi | that way the testing equivalents of them can be committed together as well | 16:51 |
| corvus | and i believe we have started storing some public keys in secret ansible vars | 16:51 |
| clarkb | ya that is one solution | 16:51 |
| clarkb | I'll redo my change to operate under that assumption | 16:51 |
| fungi | it's not ideal, i don't especially like putting non-sensitive material in the secret store, but when there's a technical reason to do that because it simplifies things, i think it's an acceptable tradeoff | 16:52 |
| corvus | fungi: if it helps soften the blow, keeping related data together makes maintenance easier :) | 16:52 |
| fungi | yes. yes it does | 16:52 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve gerrit known_hosts management https://review.opendev.org/c/opendev/system-config/+/802922 | 16:53 |
| clarkb | that modifies the known_hosts management but then only sets up values in system-config for the test env. After (or before I suppose) we merge that we can add the contents for prod from the previous patchset to the private vars | 16:54 |
| clarkb | I expect that will pass testing and be mergeable if reviewers are happy with it | 16:54 |
| opendevreview | Merged opendev/system-config master: Run matrix-eavesdrop on eavesdrop https://review.opendev.org/c/opendev/system-config/+/800320 | 17:00 |
| opendevreview | Merged opendev/system-config master: Run matrix-gerritbot on eavesdrop https://review.opendev.org/c/opendev/system-config/+/800506 | 17:00 |
| clarkb | HPE reports an interesting issue around gerrit mergability checks. TL;DR for us is do not force merge a change if gerrit errors when determinining mergability for that change. You'll cause that error to be present on all changes | 17:06 |
| clarkb | all changes in the repo (or maybe just branch on that repo) | 17:06 |
| fungi | ouch | 17:06 |
| clarkb | ya I think the important thing to take from this is if gerrit has fundamental errors then force merging is only going to cause more problems | 17:09 |
| clarkb | its ok as long as you keep them contained to a specifi cchange. Just make a new one constructed differently | 17:09 |
| fungi | yeah, basically you don't want those to be on a tracked branch | 17:09 |
| clarkb | the gitea build fails. I guess it is a good thing we are testing this early. | 17:19 |
| opendevreview | Merged opendev/system-config master: Add mailing list for FLOSS MOOC https://review.opendev.org/c/opendev/system-config/+/797549 | 17:20 |
| clarkb | I think that maybe the issue is due to a new nodejs release? | 17:26 |
| fungi | i'll check in a bit to see if the deploy for that ^ does what we expect | 17:26 |
| opendevreview | Clark Boylan proposed opendev/system-config master: WIP Prepare gitea 1.15.0 upgrade https://review.opendev.org/c/opendev/system-config/+/803231 | 17:29 |
| clarkb | trying a different nodejs version though they all got updated a couple of days ago | 17:29 |
| clarkb | I'll file an upstream bug with gitea if this seems persistent | 17:29 |
| clarkb | nodejs 12 seems to build gitea just fine. I'll let that run through fully to idnetify any othe rissues but then revert back to nodejs 16 and if that fails file a bug upstrema | 17:55 |
| clarkb | I think upstream is using nodejs 14 despite the changelog saying they use 16 | 18:04 |
| clarkb | I'll actually do another followup that uses 14 to gather that info. But I suspect the pin of alpine to 3.13 is pinning nodejs to 14.17.4 which may be working but 16.6.0 is not | 18:05 |
| clarkb | 12.22.0 appears to work too | 18:05 |
| mordred | clarkb: ++ | 18:06 |
| clarkb | and the reason they pinned alpine is really interesting https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2 | 18:14 |
| clarkb | which takes us to https://github.com/opencontainers/runc/issues/2151 | 18:15 |
| clarkb | we should avoid these issues because buster isn't that new but a really interesting interaction | 18:16 |
| fungi | yeah, if we switch to bullseye we may want to double-check that | 18:19 |
| fungi | i see https://github.com/rhboot/shim-review/issues/137 linked in there talking about bullseye | 18:19 |
| clarkb | its not clear to me if you need to explicitly enable seccomp features or if they are enabled by default in such a way that things break. It seems like they may be enabled by default | 18:21 |
| clarkb | fungi: good news is our testing should check things for us I think? Maybe not to that depth though. But we'll build with all the same docker and kernel and so on as prod and can inspect that I suspect | 18:22 |
| fungi | if it prevents gitea from running then yeah | 18:22 |
| clarkb | it breaks something to do with git pushes | 18:23 |
| clarkb | and our test job does push sytem-config in there for verification purposes | 18:23 |
| clarkb | it takes the local system-config that the test is running off of and puts that into gitea | 18:23 |
| fungi | ahh, yeah | 18:23 |
| opendevreview | Clark Boylan proposed opendev/system-config master: WIP Prepare gitea 1.15.0 upgrade https://review.opendev.org/c/opendev/system-config/+/803231 | 18:38 |
| clarkb | the previous patchset did fail functional testing. Looks like anonymous cloning failed? | 18:38 |
| clarkb | but it built which is good enough for now | 18:38 |
| tristanC | corvus: the default access token should work just fine | 18:39 |
| clarkb | ya it failed to serve the robots.txt too | 18:40 |
| clarkb | user redirect does not exist [name: robots.txt] <- is the error message | 18:52 |
| clarkb | and we get unauthorized for the diskimage-builder clone | 18:53 |
| clarkb | Move (custom) assets into subpath `/assets` (#15219) <- I wonder if that is related to the robots.txt issue | 18:54 |
| clarkb | https://github.com/go-gitea/gitea/pull/15219 that does mention robots.txt | 18:56 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Permit specification of extra bootstrap packages https://review.opendev.org/c/openstack/diskimage-builder/+/802592 | 18:57 |
| clarkb | I think favicon handling might not be working in gitea, but I'll need to hold a node to be sure. | 19:08 |
| opendevreview | Clark Boylan proposed opendev/system-config master: WIP Prepare gitea 1.15.0 upgrade https://review.opendev.org/c/opendev/system-config/+/803231 | 19:11 |
| clarkb | time for lunch then I'm going to file a bug about the nodejs 16 issue then check if favicons are broken holding for ^ and file a bug for that if so | 19:13 |
| clarkb | ianw: fungi: separately it would probably be good if we can host the opendev logo for lodgeit and for gerrit theming directly on thoes servicesso that we don't have to do a dance with them | 19:14 |
| clarkb | ianw: fungi: if you can look into that that would probably be good. The diff for the ps above captures where those will need to be updated | 19:14 |
| clarkb | (I mention you since I htink you added them to the respective systems) | 19:14 |
| fungi | infra-prod-base failed in deploy on autoremoving packages from static01 | 19:23 |
| fungi | grub-install: error: cannot find EFI directory. | 19:23 |
| fungi | the workaround was creating efi mounts on servers? | 19:24 |
| fungi | yeah, looks like we've added "LABEL=UEFI /boot/efi vfat defaults 0 0" to fstab on other servers | 19:25 |
| fungi | should i do the same to static01? | 19:25 |
| Clark[m] | Does that device exist? If it doesn't then that may break the ability to boot? | 19:31 |
| fungi | well, obviously i'd test mounting it from the shell ;) | 19:36 |
| fungi | /dev/xvda15 105M 8.9M 96M 9% /boot/efi | 19:37 |
| fungi | looks like it does | 19:37 |
| clarkb | then ya I expect that would fix it | 19:43 |
| fungi | i'm going to manually re-run `apt-get autoremove -y` there now to make sure it's no longer bailing with an error | 19:44 |
| fungi | Setting up grub-efi-amd64-signed (1.167~18.04.5+2.04-1ubuntu44.1.2) ... | 19:45 |
| fungi | Installation finished. No error reported. | 19:45 |
| fungi | exit code was 0 | 19:45 |
| fungi | so that seems to have solved it now | 19:45 |
| fungi | looks like that was the only failure logged from the job, so it should be back to passing on the next deploy | 19:46 |
| fungi | also infra-prod-service-lists is finally building now | 19:46 |
| fungi | http://lists.opendev.org/cgi-bin/mailman/listinfo already shows a floss-mooc ml | 19:46 |
| fungi | diablo_rojo_phone: ^ hopefully you've received an initial message with the admin login for that | 19:47 |
| fungi | i have a feeling the job is going to time out. the last thing ansible logged is that it's running "TASK [mailman-list : Create the site list if it doesn't exist]" 15 minutes ago | 19:59 |
| fungi | looks like there's a newlist command in the process table on the lists server since all that time too | 20:00 |
| fungi | root 20094 0.0 0.3 57016 15740 pts/0 S+ 19:44 0:00 /usr/bin/python /usr/sbin/newlist floss-mooc knelson@... | 20:01 |
| fungi | why is that hanging? | 20:01 |
| clarkb | is it trying to prompt for a password? or maybe it wants the user to ack it via email? | 20:01 |
| fungi | strace on that process shows it's on a read() | 20:02 |
| clarkb | fungi: the one thing we change between testing and prod is that we don't allow testing to send the email notifications | 20:02 |
| fungi | yeah, i bet that's it, probably didn't pass the right option to newlist, checking the manpage now | 20:02 |
| clarkb | https://github.com/go-gitea/gitea/issues/16604 has been filed | 20:03 |
| fungi | i suspect you're right that it's prompting for a password nobody will ever be there to enter | 20:03 |
| clarkb | fungi: we should be passing it on the command line though iirc | 20:03 |
| fungi | we are, it's showing in the command line string in the process table | 20:03 |
| clarkb | but ya maybe something with the command construction | 20:03 |
| clarkb | like we need an extra flag? I dunno | 20:03 |
| fungi | newlist [options] [listname] [listadmin-addr] [admin-password] | 20:03 |
| fungi | (from its manpage) | 20:03 |
| fungi | "You can specify as many of the arguments as you want on the command line: you will be prompted for the missing ones." | 20:04 |
| fungi | but yeah, the three required parameters are on the command line | 20:06 |
| fungi | we don't pass any options, but that should be fine? | 20:06 |
| clarkb | fungi: unless we need to pass an option. testing passes the don't send email option | 20:07 |
| clarkb | maybe there is a positive send email option we need to specify? | 20:07 |
| clarkb | and we are being prmopted to specify whether or not we want to do that? | 20:07 |
| clarkb | fungi: ya the --quiet option says that it supresses a prompt | 20:15 |
| clarkb | I bet that is it | 20:15 |
| clarkb | er wait is that for mailman3 though? | 20:15 |
| clarkb | "Normally the administrator is notified by email (after a prompt) that their list has been created. This option suppresses that notification and the prompting" | 20:16 |
| clarkb | that is indeed in mailman2. How was puppet doing it if not prompting? Maybe it was feeding the prompt a response? | 20:16 |
| fungi | i'm looking at the newlist manpage on lists.o.o | 20:16 |
| fungi | so not mailman3 | 20:17 |
| fungi | but that much seems to be the same | 20:17 |
| clarkb | My strong hunch here is that testing works because we pass --quiet becuse we don't want to email people every time we run the tests. But when we create a new list for real we do want to email them | 20:17 |
| fungi | the options newlist claims to support here at --language --urlhost --emailhost --quiet | 20:18 |
| fungi | looks like not passing those should be fine | 20:18 |
| clarkb | yes, but it prompts if you don't pass --quiet | 20:18 |
| clarkb | also note the list was created lending more evidence to the idea that it is simply prompting about sending the notification | 20:18 |
| clarkb | that is really annoying that it doesn't have a just send the email flag | 20:18 |
| fungi | mmm, yes | 20:19 |
| clarkb | I think the old puppetry must've repsonded to that prompt | 20:19 |
| clarkb | and now we aren't | 20:19 |
| fungi | yeah, i suspect so, digging up the source for that module now | 20:20 |
| clarkb | fungi: https://opendev.org/opendev/puppet-mailman/src/branch/master/lib/puppet/provider/mailman_list/mailman.rb#L69-L93 | 20:20 |
| fungi | i don't see where it's interacting with the process there, just building up the command line | 20:22 |
| clarkb | fungi: I think line 91 calls the process | 20:23 |
| fungi | right, but not seeing where it would interact with it after calling | 20:24 |
| clarkb | ya it would likely need to be some sort of ruby magic in the provider type's handling of the commands list? | 20:25 |
| fungi | the newlist command is still hanging on the server, but the job timed out | 20:28 |
| clarkb | `stdin = Puppet::FileSystem.open(options[:stdinfile] || null_file, nil, 'r')` https://www.rubydoc.info/gems/puppet/Puppet%2FUtil%2FExecution%2Eexecute | 20:28 |
| fungi | here's another possibility... could the ssh options be doing something which causes the process to simply not terminate due to inherited descriptors? | 20:28 |
| clarkb | fungi: I suspect the ansible playbook is still running | 20:28 |
| clarkb | fungi: no I strongly suspect that we are being prompted to confirm we want to send the email | 20:29 |
| clarkb | fungi: it seems that current puppet at least provides an explicit nil stdin which probably bypasses all that? | 20:29 |
| fungi | i guess if we </dev/null that would work? | 20:29 |
| clarkb | fungi: it might, I have held nodes for testing mailman stuff we can test it on. I suspect we'll need to kill the newlist and cause that ansible playbook run to clean itself up though | 20:30 |
| fungi | and yeah, could be newlist attempts to perform tty detection and ansible is fooling it into thinking there's a user at the other end of the pipe | 20:30 |
| clarkb | yes exactly | 20:31 |
| fungi | </dev/null is the usual way around that sort of smartness | 20:31 |
| clarkb | fungi: you'll need to convert the command task to a shell task to do that. I wonder if ansible has a flag to do that | 20:32 |
| clarkb | fungi: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/command_module.html#parameter-stdin is a possible alternative | 20:32 |
| fungi | yeah, i just tested and it does prompt to hit enter to send the notification | 20:33 |
| clarkb | fungi: did you test that on my test node or the prod server? note I think it will actually create the list for you even though the command is prompting | 20:34 |
| fungi | and if i tack on /dev/null it skips right on past the prompt | 20:34 |
| fungi | yes, i created a test list on there and set it to notify my personal addy | 20:34 |
| fungi | and then tested again with a different listname and the null stdin | 20:34 |
| clarkb | cool just wanted to point out if testing on the prod server that you need to clean it up. | 20:35 |
| fungi | received both notifications | 20:35 |
| fungi | i did not test on production, no ;) | 20:35 |
| clarkb | fungi: ok that gives us a method to fix things for future newlist runs. What do we think we want to do for the process on the prod server? If we kill it I'm not sure if other newlist tasks will compelte | 20:35 |
| clarkb | I suppose we can kill it, then manually delete the list. Fix ansible then rerun the playbook | 20:36 |
| fungi | so anyway, i'm now fairly certain that 1. it's hanging at the hit enter to notify prompt, and that if we can figure out how to set stdin to /dev/null it will work as intended | 20:36 |
| clarkb | fungi: setting stdin to /dev/null is easy in the ansible. Just change the command task to a shell task and add that bit to the command string | 20:36 |
| fungi | yes, i think killing the newlist process will likely be all we need to do, if the last step it performs is the notification. i can just notify diablo_rojo_phone of the initial password after double-checking the list is really there and has an initial config | 20:37 |
| clarkb | fungi: ok | 20:37 |
| fungi | clarkb: alternatively, do command tasks have an option for setting the file descriptors on them in ansible itself? | 20:37 |
| clarkb | fungi: see my link above https://docs.ansible.com/ansible/latest/collections/ansible/builtin/command_module.html#parameter-stdin looks like you can give it a string value | 20:38 |
| clarkb | fungi: looks like you could set stdin to '' and ansibel will append a newline to that by default | 20:38 |
| clarkb | fungi: maybe test that ^ | 20:38 |
| clarkb | just create a file with a newline in it for that and < file into the command? | 20:39 |
| fungi | yeah, that works too | 20:40 |
| fungi | just tested, and it notified me | 20:40 |
| clarkb | in that case I think you can add stdin: '' to the command task | 20:40 |
| fungi | created a file named newline that was just a linefeed character and then added <newline | 20:40 |
| clarkb | I expect that will mimic what ansible does via the string | 20:41 |
| fungi | it does look like the floss-mooc ml was successfully created and i'm able to browse its configuration in the webui after logging in with the admin password i see on the command line for the hung process | 20:43 |
| clarkb | yay to testing. I think our rename playbook doesn't work with gitea 1.15.0 and that is why I'm failing now | 20:43 |
| fungi | i've passed the initial pw for the floss-mooc ml to diablo_rojo_phone out of band | 20:46 |
| fungi | i killed the newlist command and ansible seems to have wrapped up the task for it now | 20:47 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Skip notification prompt for newlist command https://review.opendev.org/c/opendev/system-config/+/803263 | 20:52 |
| fungi | clarkb: ianw: ^ | 20:53 |
| *** dviroel is now known as dviroel|out | 20:53 | |
| fungi | clarkb: is proposed-cleanups.20210727 (73 lines) the one you want sanity-checked? | 20:54 |
| clarkb | fungi: yup and there should be a corresponding audit file | 20:59 |
| clarkb | fungi: note an unrelated change snuck into 803263 | 21:00 |
| clarkb | fungi: left notes on that change | 21:01 |
| fungi | oops | 21:01 |
| clarkb | "Repository transfer has to be confirmed, if user can not create repo for new owner (#14792)" I wonder if the determination for that has changed in 1.15.0 | 21:04 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Skip notification prompt for newlist command https://review.opendev.org/c/opendev/system-config/+/803263 | 21:04 |
| fungi | clarkb: ^ thanks for spotting! | 21:04 |
| fungi | no clue how that happened | 21:04 |
| fungi | i might have inadvertently hit the checkout button in gertty or something | 21:04 |
| clarkb | fungi: did you see the notes on the other file? | 21:04 |
| fungi | not yet but fixing now | 21:05 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Skip notification prompt for newlist command https://review.opendev.org/c/opendev/system-config/+/803263 | 21:06 |
| fungi | clarkb: ^ and fixed, thanks again! | 21:06 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Use nodejs 14 https://review.opendev.org/c/opendev/system-config/+/803265 | 21:10 |
| clarkb | that change should be mergeable and is better reflection of how things are built upstream | 21:11 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve repo rename functional testing https://review.opendev.org/c/opendev/system-config/+/803266 | 21:13 |
| clarkb | and that adds a bit more testing around renames that I noticed we should probably have while trying to debug the failed rename with gitea v1.15.0-rc2 | 21:13 |
| opendevreview | James E. Blair proposed opendev/system-config master: Remove comment from matrix-eavesdrop dockerfile https://review.opendev.org/c/opendev/system-config/+/803267 | 21:23 |
| corvus | i'm self-approving that so we can get an image build | 21:23 |
| corvus | (due to a misconfiguration since fixed, we have not yet run a promote job followed by an upload job for that image) | 21:24 |
| opendevreview | Clark Boylan proposed opendev/system-config master: WIP Prepare gitea 1.15.0 upgrade https://review.opendev.org/c/opendev/system-config/+/803231 | 21:34 |
| clarkb | that rewrites things in the rename playbook to use the gitea rest api to trasnfer and rename repos | 21:34 |
| clarkb | I don't actually know if that will work but I suspect that if I submit a bug saying hacking the web ui to transfer and rename things doesn't work anymore we'll get laughed at and pointed to the api :) | 21:35 |
| clarkb | if the api doesn't work then we can file bugs against it | 21:35 |
| clarkb | ianw: it seems we need to prune backup02. Do we just run the script for that? I also notice it has review-dev contents on it that may be deletable? | 21:36 |
| clarkb | I need to work on the meeting agenda shortly. Please add your entries there for tomorrow | 21:37 |
| clarkb | infra-root https://review.opendev.org/c/opendev/system-config/+/802922 does pass testing. If you can review it and it gets some +2's I'll modify the private vars to include the known hosts we want in production before we land it | 21:40 |
| corvus | clarkb: i think with that zuul stack under control i can take a look at that now (istr i did some of the original work on that -- but maybe the rest api wasn't fleshed out enough at the time) | 21:48 |
| clarkb | corvus: ya I think there may be some other places we can do similar cleanups, but right now my goal is largely just to get the v1.15.0-rc2 release happy (so that we are prepared for that release) | 21:49 |
| clarkb | corvus: generally converting to the api where we can seems like a good idea though | 21:50 |
| corvus | clarkb: ++ on all | 21:50 |
| corvus | clarkb: i want to say it was specifically the transfer method that didn't exist at the time? | 21:50 |
| clarkb | corvus: that wouldn't suprise me. It does seem to be in the current swagger doc though | 21:51 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Skip notification prompt for newlist command https://review.opendev.org/c/opendev/system-config/+/803263 | 22:04 |
| clarkb | fungi: ^ fixed up an ansible format problem there | 22:04 |
| ianw | clarkb: ok, yep we can just run the script to prune backup, but yeah i can look at cleanup of review-dev first | 22:06 |
| clarkb | thanks | 22:07 |
| clarkb | not sure if any of the review-dev stuff is worth keeping, that server had been largely unused once review-test happened | 22:08 |
| corvus | ianw, mordred: can you take a look at the comment i wrote in https://review.opendev.org/803123 about the containerfile image builds | 22:09 |
| ianw | we fiddle resolv.conf in project-config elements right? | 22:12 |
| ianw | there has been stuff about resolv.conf being symlinks, etc. in the past and i'll have to context switch it back in | 22:13 |
| clarkb | agenda sent. I'm going to dive into some zuul reviews now | 22:14 |
| ianw | https://opendev.org/openstack/project-config/src/branch/master/nodepool/elements/nodepool-base/finalise.d/89-boot-settings#L205 | 22:15 |
| ianw | is what i'm thinking of | 22:15 |
| corvus | ianw: aha, so that's what's making it work -- but containerfile or fedora-containerfile wouldn't work without that | 22:17 |
| corvus | (and since that's in openstack/project-config -- that's not ideal for an element in DIB itself) | 22:18 |
| corvus | ianw: i think the best thing to do for an ubuntu:focal image would be to create the symlink in an early finalize.d script, then that project-config script could override it (just as it does for debootstrap builds) | 22:20 |
| corvus | ianw: what do you think about doing that in general, and if it's a good solution, do you think it should be in ubuntu-containerfile, or should we put it in containerfile? | 22:21 |
| ianw | i'll have to think about it an page back in the thinking behind the .ORIG file copy | 22:22 |
| clarkb | I marked https://review.opendev.org/c/opendev/system-config/+/803231 WIP so that we don't accidentally land that change before the 1.15.0 gitea release happens | 22:40 |
| opendevreview | Merged opendev/system-config master: Remove comment from matrix-eavesdrop dockerfile https://review.opendev.org/c/opendev/system-config/+/803267 | 22:41 |
| corvus | ianw: thanks; hopefully those notes help -- i found grepping a build log for 'resolv.conf' helped too. | 23:25 |
| corvus | ianw: theres good comments on the intention behind .ORIG -- it just understandably didn't take into account the idea that both the base image would have a garbage resolv.conf and the case where there are no installs after that to fix it. | 23:27 |
| clarkb | infra-root I think https://review.opendev.org/c/opendev/system-config/+/803265 and https://review.opendev.org/c/opendev/system-config/+/803266/1 are safe cleanups/improvements to the gitea building and testing process. The first one will cause a new image to be built and deployed though. I'm happy to approve that when I can watch it if ya'll prefer | 23:29 |
| clarkb | but would be good to land those then we'll be in a good spot to rebase the v1.15.0 change on that and get even more better testing | 23:29 |
| clarkb | fungi: https://review.opendev.org/c/opendev/system-config/+/803263 passes testing now | 23:36 |
| fungi | thanks for the fix-up! | 23:49 |
| opendevreview | James E. Blair proposed opendev/system-config master: matrix-eavesdrop: fix initial room path creation https://review.opendev.org/c/opendev/system-config/+/803294 | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!