Friday, 2020-12-04

*** sshnaidm|afk has joined #opendev00:20
*** sshnaidm|afk is now known as sshnaidm|off00:20
*** deepthot has quit IRC00:26
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: ensure-podman: Use official podman repos for ubuntu  https://review.opendev.org/c/zuul/zuul-jobs/+/76517700:28
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: ensure-podman: Use official podman repos for ubuntu  https://review.opendev.org/c/zuul/zuul-jobs/+/76517700:30
*** mlavalle has quit IRC00:40
*** hamalq has quit IRC00:54
*** guilhermesp has quit IRC00:56
*** gouthamr has quit IRC00:57
*** mnasiadka has quit IRC00:57
*** guilhermesp has joined #opendev00:58
*** mnasiadka has joined #opendev00:58
*** gouthamr has joined #opendev00:58
*** tosky has quit IRC01:01
openstackgerritJeremy Stanley proposed opendev/system-config master: Add an OpenDev theme into our Gerrit image  https://review.opendev.org/c/opendev/system-config/+/76542201:27
*** brinzhang has joined #opendev01:32
*** openstackgerrit has quit IRC01:37
fungistruggling on https://review.opendev.org/765422 with figuring out where docker copies files from02:10
*** brinzhang has quit IRC03:31
*** brinzhang has joined #opendev03:31
*** ykarel|away has joined #opendev04:53
*** ykarel|away is now known as ykarel04:53
*** brinzhang has quit IRC05:16
*** brinzhang has joined #opendev05:16
*** whoami-rajat__ has quit IRC05:19
*** whoami-rajat__ has joined #opendev06:18
*** ysandeep|away is now known as ysandeep06:55
*** lpetrut has joined #opendev07:06
*** marios has joined #opendev07:17
*** eolivare has joined #opendev07:26
*** lpetrut has quit IRC07:46
*** DSpider has joined #opendev07:52
*** tkajinam has quit IRC08:31
*** tkajinam has joined #opendev08:32
*** tosky has joined #opendev09:05
*** lpetrut has joined #opendev09:07
*** ysandeep is now known as ysandeep|lunch09:12
*** fressi has joined #opendev09:13
*** lourot has quit IRC09:17
*** lourot has joined #opendev09:18
louroto/ we ( #openstack-charms ) used to have a bot posting gerrit reviews in our channel. It's not posting anymore. Is it a known issue? thanks!09:46
*** brinzhang has quit IRC10:06
*** brinzhang has joined #opendev10:06
*** chengsheng has left #opendev10:19
*** chengsheng1 has joined #opendev10:43
*** chengsheng1 is now known as chengsheng10:43
*** chengsheng has quit IRC10:45
*** chengsheng1 has joined #opendev10:48
*** chengsheng1 is now known as chengsheng10:50
*** hashar has joined #opendev10:51
*** ysandeep|lunch is now known as ysandeep11:13
*** cgoncalves has quit IRC12:45
*** cgoncalves has joined #opendev12:46
*** cgoncalves has quit IRC12:47
*** weshay|pto is now known as weshay|ruck12:49
*** ysandeep is now known as ysandeep|mtg13:33
*** cgoncalves has joined #opendev13:40
gibilourot: I think this is a common problem, as I don't see the bot posting in #openstack-nova too13:49
mnaserinfra-root: ^ the bot might need a rekick13:50
*** mlavalle has joined #opendev13:59
*** tkajinam has quit IRC14:07
*** hashar has quit IRC14:08
*** ysandeep|mtg is now known as ysandeep14:19
*** brinzhang has quit IRC14:28
fungi2020-12-04 01:37:59     <--     openstackgerrit (~openstack@eavesdrop01.openstack.org) has quit (Quit: Changing servers)14:35
*** kevinz has quit IRC14:35
fungiyeah, looks like maybe it didn't reconnect after freenode was doing some server restarts14:35
fungi#status log restarted gerritbot as it did not realize it was no longer connected to freenode14:37
openstackstatusfungi: finished logging14:37
fungilourot: gibi: mnaser: thanks for the heads up14:37
*** openstackgerrit has joined #opendev14:47
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: ensure-podman: Use official podman repos for ubuntu  https://review.opendev.org/c/zuul/zuul-jobs/+/76517714:47
*** fressi has quit IRC14:47
*** ysandeep is now known as ysandeep|away15:23
*** ysandeep|away is now known as ysandeep15:46
*** ysandeep has quit IRC15:52
*** odyssey4me has quit IRC15:52
*** ysandeep has joined #opendev15:53
*** odyssey4me has joined #opendev15:53
*** ykarel has quit IRC16:17
*** marios is now known as marios|out16:22
zbrhttps://review.opendev.org/c/opendev/gerritbot/+/765130 -- to make gerritbot skip notifications about WIP changes, less noise better notifications.16:22
zbri does also start to notify us when a change moves from WIP to ready. which current one does not.16:22
*** ysandeep is now known as ysandeep|away16:28
*** ralonsoh has quit IRC16:35
*** mlavalle has quit IRC16:35
*** ralonsoh has joined #opendev16:35
*** mlavalle has joined #opendev16:36
fungiclarkb: i'm struggling on https://review.opendev.org/765422 with figuring out where docker copies files from, what am i overlooking?16:43
clarkblooking16:43
clarkbfungi: hrm that looks right, it should be relative to the Dockerfile16:44
fungii just need docker build to copy a file from the git repo into the image16:44
fungibut the build job is complaining the file is not found16:44
clarkblet me see where we put the release.way16:45
clarkb*.war16:45
fungiper the error it's looking in /var/lib/docker/tmp/docker-builder070577660/16:46
fungibut i don't know enough about docker to guess whether that's normal, where we're setting it if not, and why the files from the git repo aren't there16:46
clarkbfungi: it seem we copy release.war to /home/zuul/src/gerrit.googlesource.com/gerrit https://zuul.opendev.org/t/openstack/build/f03e6e620afd481cb19980aadea5af6e/console#5/1/0/ubuntu-bionic16:47
*** chandankumar is now known as raukadah16:47
clarkbfungi: ya I think the docker build command is changing its relative dir on the host?16:48
fungioh, yep so we tell docker build to act on /home/zuul/src/gerrit.googlesource.com/gerrit rather than using the homedir16:48
fungier, rather than using the pwd16:49
clarkbya after cd'ing into the dir with the Dockerfile16:49
clarkbI think in that case you can copy the file into the gerrit dir like the war ? or we can figure out why it is done that way and maybe reorient around system-cofnig instead?16:49
clarkbif we've got the way already I don't think we need any of the gerrit src context16:49
clarkband I can't type war16:49
*** hashar has joined #opendev16:50
fungii'm not following "copy the file into the gerrit dir like the war"16:51
fungii thought that's what i was doing16:51
clarkblet me get a link16:51
fungiwe "COPY release.war /var/gerrit/bin/gerrit.war"16:51
fungibut by then we're already in /home/zuul/src/gerrit.googlesource.com/gerrit16:52
clarkbfungi: https://opendev.org/opendev/system-config/src/branch/master/roles/bazelisk-build/tasks/main.yaml#L1216:52
clarkbyup and ^ copies release.war into /home/zuul/src/gerrit.googlesource.com/gerrit16:52
clarkbthat is why the COPY in the dockerfile works16:52
fungiso do it with ansible instead of with docker?16:52
fungithis seems like it complicates trying to build images locally16:53
clarkbI think the two main options here are to do a copy like https://opendev.org/opendev/system-config/src/branch/master/roles/bazelisk-build/tasks/main.yaml#L12 for the html or update that ansible to copy into system-config/docker/gerrit/bazel/ then switch the dir relative for the image build16:53
clarkbfungi: yes you basically can't build these images locally16:53
fungiahh, okay16:53
clarkbwe assume you've got a gerrit buildchain external to the image builds themselves16:53
fungii'll try to figure out how to ansible it into the image then16:54
fungii kinda get why you can't build gerrit itself from the dockerfile, but this is just a static file we want to include in a set path in the image16:54
clarkbwell you should be able to build the gerrit war in a throw away image then copy the result just like we do with python packages16:55
clarkbbut I'm sure there were problems with that appraoch I don't fully understand16:55
clarkbI think some of it is in getting the zuul goodness for git repo management16:55
*** lpetrut has quit IRC17:00
clarkbmaking it so the docker build also did the war build would likely be a good improvment but also not an urgent one and likely one that will melt brains17:00
*** marios|out has quit IRC17:01
*** eolivare has quit IRC17:02
clarkbthe tripleo gate resets are really expensive right now :/17:03
fungiclarkb: looking in the Run bazelisk build task, it does a chdir: "{{ zuul_work_dir }}" which defaults to the same thing as zuul.project.src_dir and we're copying bazel-bin/release.war into that dir... so can i simply cp docker/gerrit/bazel/opendevtheme.html ./ or is there more to it?17:04
clarkbfungi: in this case I think zuul_work_dir is the gerrit repo not system-config, but ya absically do something like that. maybe before we call docker build and after the war is built?17:05
fungiyeah, still attempting to dissect this and getting increasingly lost. who knew copying a file from a git repo into a docker image could be so convoluted?17:08
fungiis the proper way to do this to use a different "layer"?17:08
fungior can i add it in the gerrit-base image instead?17:09
*** chengsheng has quit IRC17:09
clarkbno I think you can ignore that, the COPY you have in the Dockerfile is fine, we just have to make sure the source side of that copy is present before running docker build17:09
clarkbfungi: basically the dockerfile copy is running relative to the dir in the docker build command line. (also I think you have to go at or below that dir you can't break out).17:13
clarkbso we need to copy the .html file into the gerrit source dir root prior to running docker build17:13
fungii'm not finding where it's overriding zuul_work_dir though in that case17:14
clarkbfungi: playbooks/zuul/gerrit/run.yaml when it runs bazelisk build17:15
clarkbalso note that jeepyb runs these jobs so not sure we can assume system-config is always the work dir either, may just need to be explicit17:16
fungiso i guess i can copy from {{ zuul.executor.work_root }}/{{ zuul.project.src_dir }}/docker/gerrit/bazel/opendevtheme.html to the current directory at the end of the Run bazelisk build shell task17:16
clarkbI wouldn't put it in run bazelisk since it isn't really related to the java build17:17
clarkbI would add in a task between the bazelisk build and the docker build in run.yaml17:17
fungioh, you're saying sometimes zuul.project.src_dir could be system-config and sometimes it could be jeepyb, so i need to specify system-config?17:17
clarkb(you may need to split it up into different plays for that?)17:17
clarkbya that too17:17
fungifor simplicity's sake it seems like it would make more sense to copy this when the built plugnis are getting copied since this is technically a plugin too17:19
fungiunless we want to treat static plugins differently from built ones17:19
clarkbwell the built plugins come out of the war17:21
fungii'll look at making a separate "copy static plugins" play/task17:21
clarkb++17:21
fungibut in that case should i really be sticking that plugin in the docker tree? probably more sensible to make it a file in the ansible role17:22
clarkbmaybe just copy everything in system-config/docker/gerrit/opendev_static_plugins to gerrit/opendev_static_plugins then thee dockerfile can COPY from there17:22
clarkbeither way would work, the upside to keeping it with the docker tree is that it will remind us we'd like to get to having docker build do everything17:22
fungiif docker's not actually sourcing it from that location and we're making a round-trip through ansible to put it in place, it'll be more likely to confuse people if we store it next to the dockerfile17:23
clarkbya thats a good point, for example the build gerrit script in docker/gerrit/bazel is completely unused iirc17:24
mordred++ to getting docker build to do everything ... fwiw, I could not get bazlisk to sanely work to do that17:24
mordredbecause it wants to be "helpful"17:24
fungithough this brings us full-circle to my original concern. we already stick other static files outside the docker image and bind-mount them in. if docker isn't going to be baking static files into our images then it seems like the static plugins would be better dealt with the same way as other static files?17:24
mordredand then for reasons I could never figure out, inside of the container build sometimes bazel would just crap the bed17:25
fungior should we be looking at moving the static files out of the system and into the docker images?17:26
clarkbfungi: ya the way I see it the static files really awnt to be part of the image because the image is also static17:27
mordred++17:27
clarkbfungi: the stuff that is bind mounted should be config or other non ephemeral stuff that changes17:27
mordredoh - so the reason for originally bind-mounting static files that weren't plugins ...17:28
fungiand this is an html file which adjusts the site theme... is that config?17:28
mordredwas to allow for updating them (like the html headers) without needing to restart gerrit by deploying a new container image17:28
clarkbfungi: I don't think so, its part of the software we deploy? I mean its all grey17:28
mordredif we bind mount them, we can push new copies of them to the host and they just update17:28
mordredif we put them int eh image, we have to restart the container process to get new versions of them17:28
mordredthus why plugins in containera nd html files out of container17:29
fungiby the same token the cla files are also html we currently ansible into the system and then bind-mount into the image17:29
clarkbmordred: I see17:29
clarkbin that case maybe we should just bind mount it in17:29
mordredyeah- really depends on how the lifecycle of the file overlaps with the lifecycle of the process17:29
clarkbbut I doubt we're gonna be changing this much once we land on a file we like17:30
mordredindeed17:30
clarkbwhere I find all the bind mounting to be problematic is running a local version of this image is a huge pita17:30
fungiand how often have we changed the icla?17:30
clarkbfungi: like twice?17:30
mordredhonestly, in that case, putting it in the image does streamline things - just at the expense of needing a restart to change later on down the road17:30
mordred++17:30
fungii think we've changed our gerrit theme more often than the cla, was my point17:30
clarkbfungi: ya thats fair17:31
clarkbanother way to look at it is how tied to a specific version of an image is a file17:31
mordredbut even that - if the javascript results table becomes a plugin17:31
fungias an aside, anybody know why we have playbooks/roles/gerrit/files/cla.html and playbooks/roles/gerrit/files/static/cla.html ? they're bitwise identical17:31
clarkbtheming is tied to gerrit versions but the icla has not been17:31
mordredit's unlikley we'll need to tweak the teme on the regular either17:31
clarkbfungi: I think because one of them was added to the roel but not written to the deployment by ansible. Then I fixed this by adding another copy not realizing the other copy existed anda ctually wrote teh copy I added17:32
clarkbfungi: the one that isn't written by ansible to the deployment should be removed17:32
fungiyeah, that's what it's looking like. i think we can remove playbooks/roles/gerrit/files/cla.html17:32
fungieverything refers to static/cla.html17:32
fungii'll add a change for that shortly17:33
clarkbfungi: maybe rm the build-gerrit.sh file in docker/gerrit/bazel too as part of that cleanup?17:33
fungican do17:33
clarkband I think docker/gerrit/bazel/Dockerfile's end bit is gerrit 2 specific and can also be removed17:34
fungiso just to make sure i'm getting this right, docker/gerrit/bazel/Dockerfile wants to copy relative to /var/lib/docker/tmp/docker-builder070577660 but we tell docker build to run relative to /home/zuul/src/gerrit.googlesource.com/gerrit so does that mean everything inside the latter gets magically copied to the former?17:35
fungilike if i put the plugin inside /home/zuul/src/gerrit.googlesource.com/gerrit i'll be able to reference it as a file in the local dir in the dockerfile?17:35
clarkbfungi: yes I think there is magic involved17:35
fungieven though the error is about not finding it in /var/lib/docker/tmp/docker-builder07057766017:35
clarkbcorrect17:36
fungii'll give that a shot17:36
fungiso if i wanted to do this as a separate play in playbooks/zuul/gerrit/run.yaml and use a copy task, do i just drop the html file into the playbooks/zuul/gerrit/ tree directly or put it in a files subdirectory like you'd do with a role structure?17:48
fungior can you have copy tasks outside a role?17:48
clarkbYou can definite copy tasks outside a role, there are file lookup rules in ansible. I don't know what they are in this case though17:49
clarkbmy hunch is in the same dir as the playbook would work17:49
clarkbhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/copy_module.html#parameter-src the docs aren't super helpful :(17:50
clarkbbut the relative statement makes me think if you put it in the same dir as the playbook then copy just that filename it would find it17:50
fungiright, that's what i was finding too17:50
fungitempted to make it a plugins subdir and copy the contents, but that's probably premature optimization until we have more than one17:51
openstackgerritJeremy Stanley proposed opendev/system-config master: Add an OpenDev theme into our Gerrit image  https://review.opendev.org/c/opendev/system-config/+/76542217:55
fungiokay, trying that ^ to see how it goes17:55
fungihopefully it's as straightforward as that17:55
clarkbfungi: I think your new task needs to happen between lines 11 and 12 of https://review.opendev.org/c/opendev/system-config/+/765422/4/playbooks/zuul/gerrit/run.yaml17:56
clarkbotherwise that looks about right17:56
fungiclarkb: oh, right, because build-docker-image is when docker will try to copy it17:59
clarkbya18:00
openstackgerritJeremy Stanley proposed opendev/system-config master: Add an OpenDev theme into our Gerrit image  https://review.opendev.org/c/opendev/system-config/+/76542218:03
openstackgerritJeremy Stanley proposed opendev/system-config master: Clean up Gerrit image builds  https://review.opendev.org/c/opendev/system-config/+/76557718:03
fungiclarkb: ^ i also stacked the requested cleanups on top18:03
clarkbthose look great thanks18:05
fungiand assuming that works, we have a slightly better idea for how to copy files into the gerrit image if we want to move more stuff out of configuration management now18:07
clarkbhttps://review.opendev.org/c/opendev/system-config/+/765021 probably fits in there somewhere too (I don't think it conflicts though? if it does I can rebase it as it is less urgent)18:09
openstackgerritGhanshyam proposed openstack/project-config master: Add 'Abandon' permission for retired repo ACL  https://review.opendev.org/c/openstack/project-config/+/76558318:21
gmannclarkb: fungi mnaser ^^ this enable the 'abandon' permission for retire repo. current TC members are not able to abandon the open review in retired/ing repo.18:21
fungigmann: that's a great idea18:22
gmannfungi: thanks18:25
fungiclarkb: infra-prod-manage-projects has been consistently succeeding since your fix went in, so i think we can consider that wrapped up: https://zuul.opendev.org/t/openstack/builds?job_name=infra-prod-manage-projects18:35
clarkbfungi: that is great news18:35
*** hamalq has joined #opendev18:36
*** hashar has quit IRC18:57
fungiinfra-root: i've pulled the latest image built from https://review.opendev.org/765422 onto https://review-test.opendev.org/ if anyone wants to check it out19:06
fungiseems to be working to me19:06
fungiseems to do well both in standard and "dark mode"19:09
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480819:11
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480819:12
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480819:27
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480819:55
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480820:11
gmannclarkb: can you check this, should be quick - https://review.opendev.org/c/openstack/project-config/+/76558320:17
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480820:21
*** ralonsoh has quit IRC20:29
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480820:32
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480820:44
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:06
fungii've temporarily set the gerrit hooks plugin's loglevel to debug so i can get a better idea of how things are being called21:11
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:13
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:24
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:36
*** mlavalle has quit IRC21:38
*** mlavalle has joined #opendev21:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:47
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480821:56
*** whoami-rajat__ has quit IRC21:57
*** tkajinam has joined #opendev22:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:07
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:26
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:29
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:34
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:43
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480822:55
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480823:10
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Zuul Cache role  https://review.opendev.org/c/zuul/zuul-jobs/+/76480823:50
*** tosky has quit IRC23:54

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!