Wednesday, 2019-09-18

openstackgerritAkihiro Motoki proposed openstack/project-config master: Stop gerrit notification to neutron-stadium specific channels  https://review.opendev.org/68277101:40
openstackgerritMohammed Naser proposed zuul/zuul-operator master: Create zookeeper operator  https://review.opendev.org/67645802:08
openstackgerritMerged openstack/project-config master: Add the gerrit checks plugin repo to Zuul  https://review.opendev.org/68275202:17
openstackgerritMerged openstack/project-config master: Add upstream Gerrit projects to OpenDev Zuul tenant  https://review.opendev.org/68275402:21
openstackgerritMerged openstack/project-config master: Add system-config and zuul to OpenDev tenant for jobs  https://review.opendev.org/68275502:21
openstackgerritIan Wienand proposed zuul/zuul master: zuul_console: fix python 3 support  https://review.opendev.org/68255603:59
openstackgerritIan Wienand proposed zuul/zuul master: Support nodes setting 'auto' python-path  https://review.opendev.org/68227503:59
openstackgerritIan Wienand proposed opendev/system-config master: logrotate: better rotation options  https://review.opendev.org/68278604:33
openstackgerritIan Wienand proposed zuul/nodepool master: Set default python-path to "auto"  https://review.opendev.org/68279705:57
openstackgerritIan Wienand proposed opendev/system-config master: logrotate: better rotation options  https://review.opendev.org/68278606:02
*** AJaeger has joined #opendev06:08
openstackgerritAndreas Jaeger proposed openstack/project-config master: Add horizon to translation jobs  https://review.opendev.org/68280806:54
openstackgerritAndreas Jaeger proposed openstack/openstack-zuul-jobs master: Use on-disk horizon dir for translations  https://review.opendev.org/68280907:03
openstackgerritAndreas Jaeger proposed openstack/project-config master: Add horizon to translation jobs  https://review.opendev.org/68280807:03
openstackgerritAndreas Jaeger proposed openstack/openstack-zuul-jobs master: Use on-disk horizon dir for translations  https://review.opendev.org/68280907:07
openstackgerritAndreas Jaeger proposed openstack/project-config master: Add horizon to translation jobs  https://review.opendev.org/68280807:08
*** AJaeger has quit IRC08:14
*** recheck has quit IRC08:20
*** recheck has joined #opendev08:24
*** AJaeger has joined #opendev08:27
openstackgerritMerged zuul/zuul master: Add no-jobs reporter action  https://review.opendev.org/68127808:36
openstackgerritMerged zuul/zuul master: Add report time to item model  https://review.opendev.org/68132308:50
openstackgerritMerged openstack/cookiecutter master: Update URLs  https://review.opendev.org/67999808:52
openstackgerritMerged openstack/project-config master: Add horizon to translation jobs  https://review.opendev.org/68280809:00
openstackgerritMerged zuul/zuul master: Add Item.formatStatusUrl  https://review.opendev.org/68132409:11
openstackgerritMerged openstack/openstack-zuul-jobs master: Use on-disk horizon dir for translations  https://review.opendev.org/68280909:19
openstackgerritAndreas Jaeger proposed openstack/openstack-zuul-jobs master: Fix horizon translation setup  https://review.opendev.org/68285009:49
openstackgerritMerged openstack/project-config master: Announce opendev/project-config changes in channels  https://review.opendev.org/68275709:50
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - fix wrong commit gitweb url  https://review.opendev.org/67994610:02
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - handle initial comment change event  https://review.opendev.org/68031010:02
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - handle Pull Request tags (labels) metadata  https://review.opendev.org/68105010:02
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - reference pipelines add open: True requirement  https://review.opendev.org/68125210:02
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - handles pull-request.closed event  https://review.opendev.org/68127910:02
*** openstackgerrit has quit IRC10:06
*** AJaeger has left #opendev10:08
*** openstackgerrit has joined #opendev10:10
openstackgerritMerged openstack/openstack-zuul-jobs master: Fix horizon translation setup  https://review.opendev.org/68285010:10
*** zbr has quit IRC10:11
*** zbr has joined #opendev10:12
openstackgerritFabien Boucher proposed zuul/zuul master: Pagure - add support for git.tag.creation event  https://review.opendev.org/67993810:30
openstackgerritMerged zuul/zuul master: Pagure - fix wrong commit gitweb url  https://review.opendev.org/67994610:57
openstackgerritAndreas Jaeger proposed openstack/project-config master: Revert "Remove accessbot from #openstack-kayobe"  https://review.opendev.org/68288112:06
*** redrobot has joined #opendev12:27
openstackgerritMerged openstack/project-config master: Revert "Remove accessbot from #openstack-kayobe"  https://review.opendev.org/68288112:31
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add scheduler config options for hold expiration  https://review.opendev.org/68267512:42
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add scheduler config options for hold expiration  https://review.opendev.org/68267512:48
openstackgerritMark Goddard proposed opendev/irc-meetings master: Remove kayobe team meeting  https://review.opendev.org/68289413:22
*** Green_Bird has quit IRC13:58
openstackgerritMerged openstack/project-config master: Stop gerrit notification to neutron-stadium specific channels  https://review.opendev.org/68277114:02
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add scheduler config options for hold expiration  https://review.opendev.org/68267514:07
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Mark nodes as USED when deleting autohold  https://review.opendev.org/66406014:12
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376214:12
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add autohold delete/info commands to web API  https://review.opendev.org/67905714:12
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Remove outdated TODO  https://review.opendev.org/68242114:12
*** openstackgerrit has quit IRC14:21
*** openstackgerrit has joined #opendev14:36
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: DNM: test prepare-workspace-git base-test  https://review.opendev.org/68291214:36
openstackgerritMerged opendev/irc-meetings master: Remove kayobe team meeting  https://review.opendev.org/68289414:57
openstackgerritMerged zuul/zuul master: Pagure - handle initial comment change event  https://review.opendev.org/68031014:59
openstackgerritMerged zuul/zuul-website master: Update to page titles and Users  https://review.opendev.org/68045915:06
openstackgerritMerged zuul/zuul master: zuul_console: fix python 3 support  https://review.opendev.org/68255615:17
*** clarkb has joined #opendev15:24
clarkbI mustve lost this channel last time I had to update weechat and it isnt in muscle memory yet to rejoin15:24
corvuspabelanger, mordred, fungi, clarkb: i'm continuing the work i started on using prepare-workspace-git15:24
corvusit looks like it's expecting a slightly different layout than what we cache on images15:25
corvus/opt/git/opendev.org/zuul/zuul-jobs  is what it wants15:25
corvus/opt/git/zuul/zuul-jobs  is what we have15:25
corvusdo we want to adjust our caching to match the role?15:25
clarkbwe should be able to modify the images to have symlinks for the old version, then switch zuul role, then delete symlinks (something like that)15:26
corvus(i'm guessing this answers the question "why didn't we get around to switching?")15:26
corvusgood idea.  i'll start on that15:26
corvuson the plus side, the "i don't have a cached image so i'll just init and push" code path works fine :)15:27
corvus(since that's what my test change ended up executing)15:27
fungiyeah, it could be done with a symlink from /opt/git/opendev.org to opt/git i suppose, but better if we populate /opt/git/ with a bunch of symlinks into /opt/git/opendev.org/ (as long as we don't create an org/namespace in opendev named "opendev.org" which seems unlikely)15:33
fungithat just needs to happen in our dib element right?15:33
corvusfungi: you said "just" does that mean you volunteer? :)15:34
clarkbfungi yes15:34
fungisure, i can take a stab at it15:34
corvus(i'm completely baffled by dib elements and am currentry trying to figure out how all this works at all)15:34
clarkbcorvus: fungi we wrote out a manifest file for a git repo managing element15:34
corvusyeah, it looks like "openstack-repos" does that15:35
corvusand then the dib upstream "source-repositories" reads it15:35
clarkbI think we need to update that manifest to change the canonical locations of the repos then for the symlinks a followup acript can create those15:35
corvushonestly, since this is a short-term thing, i think i'm in favor of the /opt/git/opendev.org -> /opt/git idea15:35
corvusthat's probably something really simple we can stick in our local manifest15:35
corvuser in our local element15:36
*** zbr has quit IRC15:36
fungiwell, the up side to a linkfarm is that once jobs are no longer using the old urls we can simply drop the routine which creates the symlinks15:36
corvusthen make the role change, then update our manifest creation step to use the new names.15:36
fungibut i suppose it's a similar amount of work either way15:36
fungithere's a loop in 50-create-repo-list main() where i think we could add the link calls15:37
fungiand makedirs15:37
corvusfungi: yeah, but is that running in the right context?15:37
fungi(for the namespaces)15:37
corvusit's an extras.d - is the target mounted then?15:37
*** zbr has joined #opendev15:38
fungioh, i see, that loop is just writing the repo list to a file15:38
clarkbya you should do it during install.d probably to avoid a bunch of pote tially broken links later15:38
corvusfungi: back to the other issue -- i think the best ordering is 1) keep the real repos at the old location; 2) symlink to them (whether individually or en masse); 3) switch roles to use the new paths; 4) drop the links and write the repos to the new location15:38
clarkbsince it will depend on what endsup on disk15:39
corvusfungi: the reason i think that's the direction we want the links is that we get better incremental testing.  3 is the first time the links get used, and it's in a controlled test change15:39
*** paladox has joined #opendev15:39
fungiindeed, looks like it's writing the repos list to os.path.join(TMP_HOOKS_PATH,'source-repository-projects-yaml') so that's probably outside the chroot15:39
corvusfungi: (if we pointed the links the other way, and we messed them up somehow, we'd fail all jobs instantly)15:39
fungiand yeah, whichever order we do it in, we need to be able to confirm jobs are using the new role before we get rid of the compatibility paths15:41
corvusfungi, clarkb: i think i grok this -- lemme try writing a change15:41
fungii guess we can delete the role before we update the clone path in dib15:41
corvusyeah that should be fine15:41
fungigranted, there are probably also projects making direct references to the old path15:41
fungiso maybe we delay removing the symlink and give them some warning15:42
corvusfungi: if there are, they're bypassing zuul and i have no sympathy15:42
fungiyeah, we normally recommend they use teh variable for the base path to the repos15:42
corvuseither the variable or the zuul path15:42
corvusbut *no one* should be touching the cached repos15:43
corvuswe don't even guarantee they are there15:43
fungii suppose it's an opportunity to root out jobs which haven't done that and get them to do it properly15:43
corvusno -- no job *ever* should have done that15:43
corvusthis isn't some migration thing15:43
clarkbya they may be stale or not even present15:43
fungiahh, right, i forgot the cached repo path is not the zuul repo path. so yeah the number of jobs referencing it should be zero15:43
corvuswell, devstack-gate did that.  but we did migrate that.  a long time ago.15:43
corvusyeah15:43
fungii had it in my head that zuul updated the cached copy rather than cloning from the cached copy and updating the clone15:44
corvusand i think the auto-migrated zuul-cloner stuff is working from the zuul-setup repos too15:44
fungiso if the zuul repositories path is not changing, then this should be fairly trivial to switch over15:44
corvusso our zuul-cloner shim shouldn't be touching these either -- but let's confirm that.15:44
fungiand in fact, if we get it wrong, jobs probably won't fail except insofar as they may timeout due to longer times for zuul to push repos onto nodes15:45
openstackgerritAndreas Jaeger proposed openstack/infra-manual master: Document "clean check" requirement  https://review.opendev.org/68293315:46
openstackgerritJames E. Blair proposed openstack/project-config master: Symlink /opt/git to /opt/git/opendev.org  https://review.opendev.org/68293415:49
openstackgerritJames E. Blair proposed openstack/project-config master: Cache repos in /opt/git/opendev.org  https://review.opendev.org/68293515:49
corvusclarkb, fungi: ^ how's that look?15:49
corvusplaybooks/legacy/pre.yaml:      repo_src_dir: "/home/zuul/src/opendev.org"15:52
corvusthat tells me that the zuul-cloner shim is cloning from the zuul homedir to wherever the job specifies, so that's all good.15:53
corvus(it does not touch the real cache dir)15:53
openstackgerritJames E. Blair proposed openstack/project-config master: Cache repos in /opt/git/opendev.org  https://review.opendev.org/68293515:54
clarkbits way to early in the morning to reason about whether or not that creates a loop15:59
* clarkb tests it15:59
*** recheck has quit IRC16:00
*** recheck has joined #opendev16:00
clarkbdoes not loop16:00
fungilrwxrwxrwx 1 fungi fungi 15 Sep 18 16:00 /home/fungi/foo/bar -> /home/fungi/foo16:01
fungiworks for me, yeah16:01
fungii mean it does allow you to do silly things like reference /home/fungi/foo/bar/bar/bar/bar16:02
fungibut we're not in the business of stopping intentional silliness16:02
clarkbya16:02
clarkbcorvus: comment on the frist change for why it failed (and how I think it can be fixed) looks good otehrwise16:03
*** zbr is now known as zbr|ruck16:07
openstackgerritAndreas Jaeger proposed openstack/infra-manual master: Document "clean check" requirement  https://review.opendev.org/68293316:08
openstackgerritJames E. Blair proposed openstack/project-config master: Symlink /opt/git to /opt/git/opendev.org  https://review.opendev.org/68293416:09
openstackgerritJames E. Blair proposed openstack/project-config master: Cache repos in /opt/git/opendev.org  https://review.opendev.org/68293516:09
corvusclarkb, fungi: ^ thanks!16:09
openstackgerritMerged opendev/irc-meetings master: Updated the Diversity WG to monthly  https://review.opendev.org/68272716:15
openstackgerritMerged openstack/openstack-zuul-jobs master: Switch project-config to promote jobs [5]: Update specs, cleanup  https://review.opendev.org/68221516:17
openstackgerritMerged openstack/project-config master: Symlink /opt/git to /opt/git/opendev.org  https://review.opendev.org/68293416:30
openstackgerritMerged zuul/zuul master: Add support for the Gerrit checks plugin  https://review.opendev.org/68077816:59
openstackgerritMerged zuul/zuul master: Update gerrit pagination test fixtures  https://review.opendev.org/68211417:08
openstackgerritMerged openstack/project-config master: Switch project-config to promote jobs [6]: Remove publish-openstack-specs  https://review.opendev.org/68221617:31
openstackgerritMerged zuul/zuul master: Support HTTP-only Gerrit  https://review.opendev.org/68193617:35
*** zbr|ruck is now known as zbr17:36
openstackgerritPaul Belanger proposed openstack/project-config master: Add windmill-ops / ansible-role-elasticsearch  https://review.opendev.org/68083017:40
openstackgerritPaul Belanger proposed openstack/project-config master: Set requireContributorAgreement false for windmill roles  https://review.opendev.org/68295417:44
openstackgerritMerged openstack/project-config master: Update gentoo image to current profile  https://review.opendev.org/68263917:47
openstackgerritClark Boylan proposed zuul/zuul-jobs master: DO NOT MERGE test cleanup phase playbook  https://review.opendev.org/68017817:49
openstackgerritMerged openstack/project-config master: Enable Review-Priority flag for Blazar  https://review.opendev.org/68261317:54
openstackgerritMerged openstack/project-config master: Fix release ACL for Kayobe  https://review.opendev.org/68258117:54
openstackgerritMerged zuul/zuul master: Add autogenerated tag to Gerrit reviews  https://review.opendev.org/68247317:59
openstackgerritMerged openstack/project-config master: Add windmill-ops / ansible-role-elasticsearch  https://review.opendev.org/68083018:18
openstackgerritMerged opendev/base-jobs master: Add cleanup playbook to all base jobs  https://review.opendev.org/68132218:19
openstackgerritMerged zuul/zuul master: Use robot_comments in Gerrit  https://review.opendev.org/68248718:19
*** openstackgerrit has quit IRC18:37
*** openstackgerrit has joined #opendev19:18
openstackgerritMerged opendev/project-config master: Add record of 20190916 gerrit project renames  https://review.opendev.org/68135319:18
openstackgerritAndreas Jaeger proposed openstack/project-config master: Remove obsolete docs publish jobs  https://review.opendev.org/68297219:34
openstackgerritClark Boylan proposed opendev/system-config master: Restore setup-org.yaml  https://review.opendev.org/68273219:41
openstackgerritDavid Shrewsbury proposed zuul/nodepool master: Reduce upload threads in tests from 4 to 1  https://review.opendev.org/68297719:41
openstackgerritAndreas Jaeger proposed openstack/project-config master: Remove obsolete docs publish jobs  https://review.opendev.org/68297219:42
openstackgerritAndreas Jaeger proposed openstack/project-config master: Remove obsolete docs publish jobs  https://review.opendev.org/68297219:46
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: RFC: Generic cache implementation  https://review.opendev.org/68299220:38
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: RFC: Generic cache implementation  https://review.opendev.org/68299220:39
openstackgerritMerged opendev/system-config master: Restore setup-org.yaml  https://review.opendev.org/68273221:11
openstackgerritTristan Cacqueray proposed zuul/zuul master: Store a list of held node per held build in hold request  https://review.opendev.org/68246621:47
openstackgerritJames E. Blair proposed zuul/zuul master: WIP: Fix gerrit errors from production  https://review.opendev.org/68300622:53
openstackgerritJames E. Blair proposed zuul/zuul master: DNM: Use http for all gerrit tests  https://review.opendev.org/68300722:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!