| kata-irc-bot | <yuchen.cc> It’s associated with issue https://github.com/kata-containers/kata-containers/issues/4714 | 04:12 |
|---|---|---|
| kata-irc-bot | <zkaiser> @bergwolf I have a doc describing why we need it in detail, is currently being reviewed, we can add it later if needed to the Kata documentation as a reference. I will share as soon as I can. | 06:46 |
| kata-irc-bot | <bergwolf> I sort of understand that we need `switch-port` for p2p capability auto-detection. Does it impose any limitation that prevents it from replacing the exiting `root-port` and `bridge-port`? Does the doc that you are working on contain such information? | 06:49 |
| kata-irc-bot | <zkaiser> Yes, it will also talk about hypervisor resource limitations and how we can avoid several broken mappings when using a `switch-port` rather then only relying on `root-ports`. | 06:50 |
| kata-irc-bot | <zkaiser> Does not impose any limitations, it is rather the contrary it allows better utilisation of hypervisor resources. | 06:51 |
| kata-irc-bot | <bergwolf> Then can we drop `root-port` completely? | 06:52 |
| kata-irc-bot | <bergwolf> I can live with three modes but can't help wondering if we can unify them ;) | 06:53 |
| kata-irc-bot | <zkaiser> I was thinking of dropping the bridge-port, but root-port is needed, there are systems that have accelerators added only to root-ports, if you use switch-port in the VM you are fooling the driver stack by saying hey you can do P2P we have a swtich where on the node you have only root-ports. | 06:54 |
| kata-irc-bot | <zkaiser> If you have like only one GPU and no P2P than use a root-port the default and do not care about switch. | 06:54 |
| kata-irc-bot | <zkaiser> If you have GPU + GPU or GPU + NIC use switch if the host has a switch to enable P2P . | 06:55 |
| kata-irc-bot | <zkaiser> We should try to keep the VM resources at a minimum. | 06:55 |
| kata-irc-bot | <zkaiser> Only do things in the VM if really needed. | 06:55 |
| kata-irc-bot | <zkaiser> So only advanced users will ever create the switch configuration for Kata, the default woudl just work. | 06:56 |
| kata-irc-bot | <bergwolf> hmm, in that case, can we detect the topology on the host, and mirror that in the guest? E.g., if a GPU is on the root port, then we hotplug it to the root port in the guest as well. If a GPU is on under a switch, then we add a switch and hotplug it in the guest too. | 06:56 |
| kata-irc-bot | <zkaiser> Exactly that is the idea. I have a follow up PR that does something like that. | 06:57 |
| kata-irc-bot | <zkaiser> Didn't want to have a huge PR that introduces "everything". | 06:57 |
| kata-irc-bot | <zkaiser> NUMA and CPU sockets are another thing we may take a look at. | 06:57 |
| kata-irc-bot | <bergwolf> Ok, I see. Then we are on the same page. Thanks a lot for the explanation and I'm looking forward to the doc that you are working on. | 06:59 |
| kata-irc-bot | <pmores> Hi! I think I've recently saw or heard a mention of a dev guide for the Rust runtime but I cannot find it on `main` or `runtime-rs`. Did I get it right, is there such a thing and if so, could someone please point me to where I can find it? Thanks and apologies for my bad memory! | 08:17 |
| kata-irc-bot | <bergwolf> @pmores this one? https://github.com/kata-containers/kata-containers/blob/runtime-rs/docs/install/kata-containers-3.0-rust-runtime-installation-guide.md | 08:29 |
| kata-irc-bot | <bergwolf> It's an installation guide. For 3.0 design, you can look at https://github.com/kata-containers/kata-containers/tree/runtime-rs/docs/design/architecture_3.0 | 08:30 |
| kata-irc-bot | <pmores> I haven't actually seen it yet so yes, that might be the one, I'll check it out, thanks! What I'm looking for more specifically is basically how to submit a PR for runtime-rs - e.g. is rustfmt required and stuff like that. | 08:42 |
| kata-irc-bot | <bergwolf> Well, I don't think we have it listed anywhere but yes, `rustfmt` is required, like in most rust projects :) | 08:47 |
| kata-irc-bot | <bergwolf> Maybe we need a few lines in the developer guide about `rustfmt` and `go fmt` in the developer guide, not just for `runtime-rs` specifically though. | 08:49 |
| kata-irc-bot | <pmores> Right, makes sense, I'll use it. Thanks! | 08:50 |
| kata-irc-bot | <pmores> Are there any other formal requirements that I should be aware of? | 09:00 |
| kata-irc-bot | <pmores> Okay, good to know, thanks! | 09:31 |
| kata-irc-bot | <chaowu9709> Hi @pmores, thanks for mentioned this:) We will also add this to the document. | 09:57 |
| kata-irc-bot | <pmores> Oh no problem, glad to be useful at least indirectly! :slightly_smiling_face: | 11:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!