Thursday, 2020-07-23

kata-irc-bot1<archana.m.shinde> @eric.ernst Take a look at this : https://github.com/kata-containers/kata-containers/pull/44201:41
kata-irc-bot1<archana.m.shinde> I am pinning to a particular version of actions, similarly applied the change for open PRs as well01:41
*** bpradipt has joined #kata-dev02:51
kata-irc-bot1<eric.ernst> K03:39
*** pcaruana has quit IRC04:17
*** pcaruana has joined #kata-dev04:17
*** amorenoz has joined #kata-dev06:16
*** amorenoz has quit IRC06:20
*** amorenoz has joined #kata-dev06:20
*** amorenoz has joined #kata-dev06:21
*** amorenoz has quit IRC06:25
*** amorenoz has joined #kata-dev06:25
*** fgiudici has joined #kata-dev07:12
kata-irc-bot1<fidencio> Done!07:18
*** snir_ has quit IRC07:35
*** snir_ has joined #kata-dev07:35
*** davidgiluk has joined #kata-dev08:06
*** sgarzare has joined #kata-dev08:08
kata-irc-bot1<thierry> Just checked and removed the Zuul SoB/WIP checks from the "required" list for repo/branches that still have them. You might have to backport those actions to all branches08:10
kata-irc-bot1<fidencio> @thierry, thanks a lot for taking care of this!08:11
kata-irc-bot1<thierry> I'll soon remove the integration so that Zuul stops running those checks on new PRs08:12
kata-irc-bot1<thierry> Just doublechecking a few things first08:12
*** sgarzare has quit IRC08:22
*** sgarzare has joined #kata-dev08:22
kata-irc-bot1<thierry> @archana.m.shinde: looks like you will have to backport adding actions to all branches, most notably kata-containers:2.0-dev08:26
*** sgarzare has quit IRC09:30
*** sgarzare has joined #kata-dev09:31
*** afrosi has joined #kata-dev10:07
*** afrosi has quit IRC10:14
*** afrosi has joined #kata-dev11:03
*** afrosi has quit IRC12:02
*** devimc has joined #kata-dev13:50
*** sgarzare has quit IRC13:56
*** sgarzare has joined #kata-dev14:01
*** devimc has quit IRC14:44
*** devimc has joined #kata-dev14:45
*** sgarzare_ has joined #kata-dev15:10
*** sgarzare has quit IRC15:13
kata-irc-bot1<archana.m.shinde> @thierry: ohh I thought just adding the checks under branch protection rules would suffice : https://github.com/kata-containers/kata-containers/settings/branches15:17
kata-irc-bot1<archana.m.shinde> let me see, I'll backport those15:17
kata-irc-bot1<thierry> @archana.m.shinde: I agree that would have been convenient :) It's confusing because the "recently-seen" tests list (the one you can choose required tests from) shows master tests  and not tests from current branch15:19
kata-irc-bot1<thierry> so you can actually put yourself in a corner mandating a test that will never run15:20
kata-irc-bot1<archana.m.shinde> I see, not good!15:21
kata-irc-bot1<archana.m.shinde> thanks for letting me know @thierry, I'll start working on backporting those changes15:21
kata-irc-bot1<thierry> np! Once enabled it seems to work pretty well (as in: triggers and reports fast)15:22
kata-irc-bot1<archana.m.shinde> yes its pretty quick15:22
kata-irc-bot1<fidencio> @archana.m.shinde, this is a good example of when exception rules would be good15:27
kata-irc-bot1<fidencio> would be nice to just have those patches pushed to all branches, without having to deal with create an issue, submit a PR, get 2 approvals ...15:28
fidenciodevimc: @amshinde: how easy is to have the link for the CI commands automatically added to the PRs? :-)15:32
devimcfidencio: I think the kata-bot can do it15:33
devimc.github/auto-comment.yml15:34
devimcfidencio: for example https://github.com/kata-containers/runtime/blob/master/.github/auto-comment.yml15:34
kata-irc-bot1<archana.m.shinde> yup, something that could be taken care of by auto-bot15:35
fidenciocool, thanks!15:35
fidenciowould be nice to have the results of the CI with some text explaining how to rerun the tests, if needed15:36
fidencioI always suffer to find the links with the commands that I need15:37
kata-irc-bot1<archana.m.shinde> agree15:38
kata-irc-bot1<archana.m.shinde> Its been on todo list for a list15:38
kata-irc-bot1<archana.m.shinde> would be useful indeed15:38
*** sgarzare_ has quit IRC16:01
davidgilukarchana.m.shinde: So are we all good now with the new qemu and kernel set?16:26
*** ailan has quit IRC17:24
*** fgiudici has quit IRC17:33
*** devimc has quit IRC17:49
*** bpradipt has quit IRC18:35
*** devimc has joined #kata-dev18:54
*** davidgiluk has quit IRC19:12
kata-irc-bot1<eric.ernst> can anyone help with getting this merged? https://github.com/kata-containers/documentation/pull/69320:51
kata-irc-bot1<eric.ernst> @archana.m.shinde can we bypass the SoB/WIP checks if that tooling is in-progress/changing over still?20:52
kata-irc-bot1<archana.m.shinde> @eric.ernst I closed and reoponed the PR for the checks to run, since they were added after your PR was raised21:04
kata-irc-bot1<archana.m.shinde> they have run now21:04
kata-irc-bot1<eric.ernst> ok.  Should we do the same for my thread model PR ? :slightly_smiling_face:21:04
*** devimc has quit IRC21:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!