| opendevreview | Merged openstack/cloudkitty master: Patch for `use_all_resource_revisions` option https://review.opendev.org/c/openstack/cloudkitty/+/895166 | 13:48 |
|---|---|---|
| opendevreview | Merged openstack/cloudkitty master: Optimize CloudKitty reprocessing process https://review.opendev.org/c/openstack/cloudkitty/+/894812 | 13:48 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Nov 27 14:00:10 2023 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Hello guys! | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| priteau | o/ | 14:00 |
| rafaelweingartner | \O | 14:00 |
| mkarpiarz | Hi! | 14:01 |
| priteau | Hello both | 14:02 |
| priteau | Let's start? | 14:03 |
| rafaelweingartner | #topic OpenSearch support | 14:03 |
| rafaelweingartner | I guess this patch is ready for further review, right? | 14:04 |
| priteau | Well, it has been ready since October 17 | 14:05 |
| priteau | Any chance we can get reviews? | 14:05 |
| mkarpiarz | It's running in my test environment. | 14:05 |
| mkarpiarz | I just need a little bit more time for testing. | 14:05 |
| mkarpiarz | So far this is looking good. :) | 14:06 |
| priteau | Also note that since it is a new storage backend, it won't be breaking any existing setup | 14:07 |
| priteau | So it is fairly safe to merge compared to something that changes existing code | 14:07 |
| rafaelweingartner | done | 14:10 |
| rafaelweingartner | I think it is almost there. | 14:10 |
| priteau | Thanks, I will reply. | 14:11 |
| rafaelweingartner | Moving on, we have the #topic Monasca deprecation | 14:11 |
| rafaelweingartner | This one is on my plate, but due to some other priorities, I have not been able to put some energy into it | 14:11 |
| rafaelweingartner | Moving on, we have the target reviews | 14:13 |
| rafaelweingartner | #topic Target reviews | 14:13 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/895166 and #link https://review.opendev.org/c/openstack/cloudkitty/+/894812 were merged, as they had two +2 | 14:14 |
| rafaelweingartner | We also have this one, #link https://review.opendev.org/c/openstack/cloudkitty/+/900205, which is regarding Monasca deprecation. It is ok to merge it. | 14:14 |
| rafaelweingartner | what do you think mkarpiarz? | 14:15 |
| mkarpiarz | Yes, let's merge https://review.opendev.org/c/openstack/cloudkitty/+/900205. | 14:16 |
| priteau | It will need backports too. | 14:17 |
| mkarpiarz | Good point! | 14:18 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Add OpenSearch as a v2 storage backend https://review.opendev.org/c/openstack/cloudkitty/+/880739 | 14:19 |
| rafaelweingartner | priteau: regarding the header. I understand the situation to duplicate the code. However, to maitain that header, it does not make much sense to me. | 14:20 |
| priteau | But it is a copyright notice. We have to keep the header as it is when we copy the code. It is the terms of the license. | 14:20 |
| rafaelweingartner | I am not sure | 14:20 |
| priteau | We could add StackHPC 2023 if it makes you happy, but the portion of the code written by StackHPC is almost none. | 14:21 |
| rafaelweingartner | Actually, I never saw much sense in those copyright, as it is an ASL 2.0 | 14:22 |
| rafaelweingartner | anyways, it just feels a bit weird to just duplicate things as is. I mean, If we use the same structure working with code extension would make more sense | 14:23 |
| rafaelweingartner | I understand that it is a lazy copy and paste because the code is the same, and then it is going to be removed the driver for ElasticSearch | 14:23 |
| rafaelweingartner | It was also feels weird to remove something that work, but again, I guess that is how OpenStack behaves | 14:24 |
| priteau | Aren't we doing the same with Monasca? ;-) | 14:24 |
| priteau | I mean, I am happy to keep the Elasticsearch driver aroud if you think it has some use. | 14:24 |
| rafaelweingartner | Monasca is a project that is not maintained anymore | 14:25 |
| priteau | But no one using CloudKitty + Kolla Ansible will use it. | 14:25 |
| rafaelweingartner | ElasticSearch is going to exist, even after OpenStack stops using it, right? | 14:25 |
| priteau | Of course, but are there going to be any user of CloudKitty + Elasticsearch? | 14:25 |
| rafaelweingartner | I do not know. Doing, the way we are doing, of course not | 14:26 |
| priteau | Did we make a survey on the mailing list? I don't remember | 14:26 |
| rafaelweingartner | because they will be forced to change | 14:26 |
| rafaelweingartner | No, we did not | 14:26 |
| priteau | We have communicated about it for several releases though | 14:26 |
| priteau | And no one has complained so far | 14:27 |
| rafaelweingartner | yes, we did. | 14:27 |
| priteau | Also it is flagged as NOT PRODUCTION READY | 14:27 |
| rafaelweingartner | I see | 14:28 |
| rafaelweingartner | I will add the +2 then | 14:28 |
| rafaelweingartner | We (my side here) might not be the best to comment on this, as we use a different backend stack | 14:29 |
| priteau | As for the copyright notice, it is usual practice to keep them as they are. As I said, if we were doing substantial changes we would add StackHPC (c) 2023, but we haven't really added or changed much code. | 14:29 |
| rafaelweingartner | I see | 14:29 |
| rafaelweingartner | Moving on, we have the following patch: #link https://review.opendev.org/c/openstack/cloudkitty/+/895685 | 14:34 |
| rafaelweingartner | I guess it can be merged. Can you take a look mkarpiarz? | 14:34 |
| mkarpiarz | Done | 14:38 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 14:39 |
| rafaelweingartner | thanks! | 14:40 |
| rafaelweingartner | priteau: it does not work if we add ciclical references | 14:41 |
| rafaelweingartner | When we tried it in https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382, it did not work | 14:42 |
| priteau | Ah, didn't notice the first one had a reference already | 14:42 |
| rafaelweingartner | we can only add in the other one, that depends on this one | 14:42 |
| rafaelweingartner | and then we merge the first patch | 14:42 |
| priteau | I will revert | 14:42 |
| rafaelweingartner | after that we merge this one | 14:42 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 14:42 |
| rafaelweingartner | Moving on, we have the patch #link https://review.opendev.org/c/openstack/cloudkitty/+/876643, which seems to be ready | 14:43 |
| rafaelweingartner | what do you guys think? | 14:43 |
| rafaelweingartner | I meant #link https://review.opendev.org/c/openstack/cloudkitty/+/876643 | 14:43 |
| mkarpiarz | I'll pull this one to my test environment just to see whether anything is missing. | 14:45 |
| rafaelweingartner | ok, thanks! | 14:45 |
| rafaelweingartner | We also have #link https://review.opendev.org/c/openstack/cloudkitty/+/861786, what do you think priteau? | 14:46 |
| mkarpiarz | I know you've said you guys are using this in production, so I don't think I'll have to test it very extensively. | 14:46 |
| rafaelweingartner | exactly | 14:46 |
| opendevreview | Merged openstack/cloudkitty master: Clean up release note https://review.opendev.org/c/openstack/cloudkitty/+/895685 | 14:46 |
| priteau | We can probably go ahead with the group-by one, it's been through many iterations | 14:48 |
| rafaelweingartner | exactly | 14:48 |
| mkarpiarz | I agree. | 14:48 |
| rafaelweingartner | therefore, I will merge this other one: #link https://review.opendev.org/c/openstack/cloudkitty/+/862824 | 14:49 |
| priteau | I didn't really review in depth the start/end date one, it is massive and a bit scary. | 14:49 |
| rafaelweingartner | which depends on that one | 14:49 |
| priteau | mkarpiarz: did you test the start/end one? | 14:49 |
| rafaelweingartner | The start/end date provides flexibility for Operators to schedule rating rules | 14:49 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty/+/876643 | 14:49 |
| rafaelweingartner | that is a very nice one to have | 14:49 |
| priteau | I left a comment on the reno, I think it can be improved. | 14:49 |
| rafaelweingartner | thanks! | 14:50 |
| rafaelweingartner | Now, last, but not least, we have SQLalchemy | 14:51 |
| rafaelweingartner | #topic SQLAlchemy 2.x / oslo.db 14.0.0 compatibility | 14:51 |
| mkarpiarz | I remember adding comments to either this change or a similar one when trying it out in my environment. | 14:51 |
| rafaelweingartner | I guess it is still a WIP, right? | 14:51 |
| priteau | It's very much a WIP | 14:51 |
| priteau | It will need several weeks (months?) of work | 14:51 |
| rafaelweingartner | I see | 14:51 |
| rafaelweingartner | If it gets to a point where you will need help, let us know | 14:52 |
| priteau | It will try to keep pushing it in December. If I see it is getting nowhere in January, I will let you know. | 14:52 |
| rafaelweingartner | Ok, thanks! | 14:53 |
| rafaelweingartner | and I guess, that is basically it | 14:53 |
| rafaelweingartner | do you guys have something else to add? | 14:53 |
| mkarpiarz | Nope | 14:54 |
| priteau | mkarpiarz: Will you have the chance to review https://review.opendev.org/c/openstack/cloudkitty/+/880739 again? | 14:54 |
| mkarpiarz | Yes, this one is on my TODO list for this week. | 14:55 |
| mkarpiarz | And like I said, it's already set up in my test environment. :) | 14:55 |
| priteau | Nothing important has changed in the latest revision | 14:55 |
| priteau | Just test code and doc. | 14:56 |
| mkarpiarz | OK | 14:56 |
| rafaelweingartner | I guess that is it for today's meeting. | 14:58 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:58 |
| priteau | Thanks both! | 14:59 |
| rafaelweingartner | #endmeeting | 14:59 |
| opendevmeet | Meeting ended Mon Nov 27 14:59:10 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-11-27-14.00.html | 14:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-11-27-14.00.txt | 14:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-11-27-14.00.log.html | 14:59 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty master: Introduce start and end dates on rating rules https://review.opendev.org/c/openstack/cloudkitty/+/876643 | 15:16 |
| opendevreview | Merged openstack/cloudkitty master: Add groupby options by different timeframes https://review.opendev.org/c/openstack/cloudkitty/+/861786 | 15:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!