| *** priteau_ is now known as priteau | 08:58 | |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add find to allowed external commands in tox https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 12:31 |
|---|---|---|
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add find to allowed external commands in tox https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 12:51 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add find to allowed external commands in tox https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 13:19 |
| rafaelweingartner | Hello guys! | 13:53 |
| mkarpiarz | Hi! | 13:59 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Jan 9 14:00:26 2023 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Hello guys! | 14:00 |
| mkarpiarz | Hi! | 14:00 |
| rafaelweingartner | I hope you all had a safe and happy hollyday season. | 14:01 |
| mkarpiarz | Thank you! | 14:02 |
| rafaelweingartner | Roll count | 14:02 |
| rafaelweingartner | \O | 14:02 |
| mkarpiarz | I'm here. | 14:03 |
| rafaelweingartner | Pierre: are you going to join us as well? | 14:07 |
| rafaelweingartner | priteau: :) | 14:08 |
| rafaelweingartner | Let's move on, and then if priteau join us, we can sync with him | 14:10 |
| priteau | Hello | 14:10 |
| rafaelweingartner | hello :) | 14:10 |
| rafaelweingartner | #topic OpenSearch support | 14:10 |
| rafaelweingartner | We need to crete the OpenSearch option in the Storage backend and deprecate elastic search. Are you priteau going to take a lead on that one? | 14:11 |
| priteau | Sorry, I missed the notification | 14:11 |
| priteau | Yes, I can work on it with some colleagues | 14:11 |
| rafaelweingartner | No worries. Thanks for taking this one up! | 14:11 |
| rafaelweingartner | #topic Monasca deprecation | 14:12 |
| rafaelweingartner | Monasca has been deprecated, and now we can remove it in the B release | 14:12 |
| rafaelweingartner | Are we all on the same page? | 14:12 |
| priteau | +1 | 14:13 |
| rafaelweingartner | ok, I will take this one when B release arrives | 14:13 |
| mkarpiarz | Yes! | 14:13 |
| rafaelweingartner | I mean, when we prepare for B release | 14:13 |
| mkarpiarz | OK | 14:13 |
| rafaelweingartner | #topic add CloudKitty API reference docs | 14:13 |
| rafaelweingartner | mkarpiarz: is taking this one | 14:14 |
| rafaelweingartner | it is almost finished, I guess | 14:14 |
| rafaelweingartner | right? | 14:14 |
| mkarpiarz | Correct. | 14:14 |
| rafaelweingartner | there is only that issue with Tox that we are addressing right now | 14:14 |
| rafaelweingartner | Thanks Mariusz! | 14:15 |
| mkarpiarz | All patches we need for this have been submitted and some of them reviewed. | 14:15 |
| rafaelweingartner | Talking about Tox, we have the following: https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 14:15 |
| mkarpiarz | But yes, #link https://review.opendev.org/c/openstack/cloudkitty/+/867628 is a blocker | 14:15 |
| rafaelweingartner | It is a bit odd, but the same tox test passes here | 14:15 |
| rafaelweingartner | but not in Zuul | 14:15 |
| rafaelweingartner | do you guys know how to check the Tox version of Zuul? | 14:15 |
| priteau | Which version of tox are you using? | 14:15 |
| priteau | It should be in the logs | 14:16 |
| rafaelweingartner | 4.2.6 | 14:16 |
| priteau | I can reproduce Zuul's failure | 14:16 |
| priteau | I have 4.2.6 too | 14:16 |
| priteau | Did you clean your tox envs? | 14:16 |
| rafaelweingartner | yes | 14:16 |
| mkarpiarz | Right, I'm still on 3.21.4... | 14:16 |
| rafaelweingartner | I deleted the .tox folder | 14:16 |
| rafaelweingartner | What is your O.S.? | 14:17 |
| rafaelweingartner | maybe there is some other library affecting us as well then | 14:17 |
| mkarpiarz | Debian 11. I'm using the "python:3.9" Docker image. | 14:18 |
| priteau | I am on macOS | 14:18 |
| priteau | Python 3.10.9 | 14:18 |
| rafaelweingartner | hmm | 14:18 |
| rafaelweingartner | I am on Ubuntu 22 | 14:19 |
| rafaelweingartner | Python 3.8.10 | 14:19 |
| rafaelweingartner | let me check with python 3.10 | 14:19 |
| mkarpiarz | OK, I'll switch to the 3.10 image then. :) | 14:19 |
| rafaelweingartner | but the weird part is that Zuul fails with python 3.8.10 | 14:19 |
| mkarpiarz | Do we have a pin for a specific version of tox or does Zuul use whatever version is in the repos? | 14:20 |
| priteau | Zuul uses the latest tox 4.x, which has caused breakage. | 14:20 |
| priteau | Stable branches should be pinned to 3.x | 14:20 |
| priteau | We have to be compatible with tox4 | 14:21 |
| priteau | Since I can reproduce locally I will check | 14:21 |
| rafaelweingartner | are you using a clean tox env? | 14:21 |
| priteau | Fixed it :) | 14:22 |
| priteau | I will push | 14:23 |
| mkarpiarz | Sure! | 14:23 |
| rafaelweingartner | ok, thanks | 14:23 |
| rafaelweingartner | it is funny, I tested with Python 3.10 here | 14:23 |
| rafaelweingartner | and it also works just fine | 14:23 |
| rafaelweingartner | there must be something else in play | 14:24 |
| mkarpiarz | So I take it for the time being we need to test against both latest tox3 and tox4? | 14:24 |
| priteau | No, just tox4 for master | 14:24 |
| priteau | tox3 for stable | 14:24 |
| rafaelweingartner | for the stable branches, we do not need to do anything I guess | 14:24 |
| rafaelweingartner | maybe, just pinning the library if needed | 14:24 |
| mkarpiarz | OK | 14:25 |
| priteau | tox is not a requirement | 14:26 |
| priteau | It's something that already lives inside the env | 14:27 |
| rafaelweingartner | priteau: so you are going to add a new patch in the open patchset? | 14:27 |
| priteau | I will update your patch with the fix | 14:27 |
| rafaelweingartner | ah ok | 14:27 |
| rafaelweingartner | thanks! | 14:27 |
| rafaelweingartner | So, we can move on with the target reviews | 14:28 |
| rafaelweingartner | #topic Target reviews | 14:28 |
| rafaelweingartner | Have you guys evaluated the spec #link ttps://review.opendev.org/c/openstack/cloudkitty-specs/+/866198? | 14:28 |
| rafaelweingartner | do you think it needs some further adjusts or changes? | 14:29 |
| priteau | I started reading yesterday but haven't been through it yet | 14:29 |
| rafaelweingartner | I see, thanks! | 14:29 |
| mkarpiarz | I must admit I have forgotten about this one. :| | 14:29 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Make tox.ini tox 4.0.0 compatible https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 14:29 |
| mkarpiarz | I'll read it as soon as this meeting ends. | 14:30 |
| rafaelweingartner | ok, thanks! | 14:30 |
| rafaelweingartner | So, moving on we have this optimization patch #link https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:31 |
| rafaelweingartner | It is an important one, can you guys review it? | 14:31 |
| priteau | Looking | 14:32 |
| opendevreview | Merged openstack/cloudkitty master: Fix typo in docs command sample https://review.opendev.org/c/openstack/cloudkitty/+/867559 | 14:33 |
| mkarpiarz | Like I said, I can't test this one at scale | 14:33 |
| mkarpiarz | but it's working in my test environment, hence the +2. | 14:33 |
| rafaelweingartner | This was a complicated one to catch | 14:34 |
| rafaelweingartner | I guess we can even do more optimizations there, but will leave it for other round | 14:34 |
| priteau | I left some minor comments | 14:35 |
| mkarpiarz | Sounds good! | 14:35 |
| priteau | Cosmetic mostly | 14:35 |
| rafaelweingartner | Thanks! | 14:37 |
| rafaelweingartner | I will address them | 14:37 |
| rafaelweingartner | So, moving on, we have the following one: https://review.opendev.org/c/openstack/cloudkitty/+/862824 | 14:37 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/862824 is a new feature that we are introducing | 14:37 |
| rafaelweingartner | There was already a round of review there, and we might need your eyes again | 14:38 |
| mkarpiarz | Does this change work for you with PyScripts enabled? | 14:39 |
| priteau | Well, I am still worried about the fact that we store this description for every dataframe | 14:39 |
| mkarpiarz | Yeah, we've had a discussion about this... | 14:40 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:43 |
| rafaelweingartner | Yes, we too worry about that | 14:43 |
| rafaelweingartner | but that is already an issue that we have | 14:43 |
| rafaelweingartner | we are storing over and over again alt_name, units, and metadata | 14:43 |
| rafaelweingartner | we have noted here a task to find an optimization for that | 14:44 |
| rafaelweingartner | so, it would optimiza all other situations and not just for descriptions | 14:44 |
| mkarpiarz | That's a fair point. | 14:44 |
| rafaelweingartner | I am not sure what you meant regarding PyScript mkarpiarz | 14:45 |
| rafaelweingartner | The fix for PyScript is the following patch #link https://review.opendev.org/c/openstack/cloudkitty/+/864578 | 14:46 |
| mkarpiarz | If you check my last comment, I said I had to disable PyScripts for 862824 to work. | 14:46 |
| rafaelweingartner | hmm | 14:47 |
| mkarpiarz | Otherwise I'd get "TypeError: 'DataFrame' object is not subscriptable". | 14:47 |
| mkarpiarz | But this could be something with my test environment. | 14:47 |
| rafaelweingartner | yes, we have it running here with PyScript | 14:47 |
| priteau | I guess it will make the storage backend more bloated only for the users of this feature | 14:47 |
| rafaelweingartner | exactly | 14:48 |
| rafaelweingartner | if you do not use it, everything will remain the same | 14:48 |
| mkarpiarz | OK, I'll try this patch again in a clean environment. | 14:48 |
| priteau | rafaelweingartner: on the Gnocchi optimisation patch, please make sure you've seen my comment: https://review.opendev.org/c/openstack/cloudkitty/+/864269/8/cloudkitty/fetcher/gnocchi.py | 14:49 |
| rafaelweingartner | ok, thanks! | 14:49 |
| rafaelweingartner | priteau: that is not going to happen | 14:51 |
| rafaelweingartner | as we check the chunk_len before using it in the expression | 14:52 |
| rafaelweingartner | chunk_len and resources_chunk[chunk_len - 1]['id'] == marker | 14:52 |
| priteau | Ah yes, of course | 14:52 |
| rafaelweingartner | If, it is 0, then it evaluates to False already | 14:52 |
| priteau | Can you make that chunk_len > 0 | 14:52 |
| rafaelweingartner | hmm | 14:52 |
| priteau | Just for clarity | 14:52 |
| rafaelweingartner | then it will make it hard to format the line :) | 14:53 |
| priteau | Nevermind then | 14:53 |
| rafaelweingartner | but I will do work around it | 14:53 |
| priteau | Also you could rename your var to just is_last or is_last_marker | 14:53 |
| rafaelweingartner | I do prefer the readability of the variable | 14:54 |
| priteau | We have different readability priorities :D | 14:54 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:55 |
| rafaelweingartner | exactly | 14:55 |
| rafaelweingartner | I tried to accomodate both | 14:55 |
| priteau | OK. I just saw two small nits, otherwise I will +2 | 14:55 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:56 |
| rafaelweingartner | Awesome, thanks! | 14:56 |
| rafaelweingartner | So, moving on to the last patch #link: https://review.opendev.org/c/openstack/cloudkitty/+/864578 | 14:57 |
| rafaelweingartner | This is also an important patch for us to move on and merge it as soon as possible | 14:57 |
| rafaelweingartner | PyScripts were broken for a long time | 14:57 |
| mkarpiarz | I agree! | 14:58 |
| mkarpiarz | We should merge this one as soon as possible. | 14:58 |
| rafaelweingartner | Guys, we are running out of time | 15:00 |
| priteau | you could be just a bit more verbose in the reno | 15:00 |
| rafaelweingartner | I guess we continue in our Async mode to review the patches | 15:00 |
| rafaelweingartner | Do you guys have something else to add? | 15:01 |
| priteau | ok | 15:01 |
| rafaelweingartner | To our meeting | 15:01 |
| mkarpiarz | I want to add that I was able to build PDF docs | 15:01 |
| rafaelweingartner | awesome! | 15:01 |
| mkarpiarz | but some lines go out of the frame and the v2 API refs are completely missing. | 15:02 |
| mkarpiarz | So this will need some work to fix. :( | 15:02 |
| priteau | It doesn't seem worth it | 15:02 |
| mkarpiarz | True, unless there is an easy way to automatically break long listings like this one: | 15:03 |
| mkarpiarz | https://docs.openstack.org/cloudkitty/latest/admin/configuration/samples/cloudkitty-conf.html | 15:04 |
| mkarpiarz | Either way, I wouldn't have time to investigate any further this week. | 15:05 |
| priteau | How many people will read our API docs in PDF? Probably none | 15:06 |
| priteau | Can we add a note that rendering is not complete? | 15:06 |
| rafaelweingartner | I agree that is is not worth it | 15:06 |
| mkarpiarz | OK | 15:06 |
| rafaelweingartner | I mean, I do not see a problem in the listing being in multiple pages | 15:06 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 15:07 |
| rafaelweingartner | #endmeeting | 15:07 |
| opendevmeet | Meeting ended Mon Jan 9 15:07:38 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:07 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-01-09-14.00.html | 15:07 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-01-09-14.00.txt | 15:07 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2023/cloudkitty.2023-01-09-14.00.log.html | 15:07 |
| priteau | mkarpiarz: can you please approve https://review.opendev.org/c/openstack/cloudkitty/+/869557? | 15:28 |
| opendevreview | Merged openstack/cloudkitty master: Make tox.ini tox 4.0.0 compatible https://review.opendev.org/c/openstack/cloudkitty/+/869557 | 16:16 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Fix PyScripts processing https://review.opendev.org/c/openstack/cloudkitty/+/864578 | 16:41 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add description option to a rating metric definition https://review.opendev.org/c/openstack/cloudkitty/+/862824 | 16:51 |
| opendevreview | Merged openstack/cloudkitty master: Add missing api-ref envlist to tox https://review.opendev.org/c/openstack/cloudkitty/+/867628 | 17:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!