| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 11:43 |
|---|---|---|
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 12:14 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add groupby options by different timeframes https://review.opendev.org/c/openstack/cloudkitty/+/861786 | 12:15 |
| rafaelweingartner | Hello guys! | 14:04 |
| rafaelweingartner | #startmeeting cloudkitty | 14:04 |
| opendevmeet | Meeting started Mon Nov 14 14:04:47 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:04 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:04 |
| rafaelweingartner | Sorry for the delay! | 14:04 |
| rafaelweingartner | Roll count | 14:05 |
| mkarpiarz | Hi! | 14:05 |
| priteau | Hello | 14:06 |
| rafaelweingartner | #topic The move from ElasticSearch and towards OpenSearch | 14:09 |
| rafaelweingartner | We discussed last week about this process, and we all agreed that it would be interesting to draft a notice message to send to the community | 14:10 |
| rafaelweingartner | Pierre have you been able to prepare something? | 14:10 |
| rafaelweingartner | When you read "last week", you should consider "last meeting" | 14:10 |
| priteau | Sorry, I was on travel all of last week. I will start a draft now. | 14:11 |
| rafaelweingartner | ok, thanks! | 14:11 |
| rafaelweingartner | #topic Monasca deprecation | 14:12 |
| rafaelweingartner | I prepared and send the e-mail querying the community about the use of Monasca | 14:12 |
| rafaelweingartner | I got no response back | 14:12 |
| rafaelweingartner | what do you guys think about that? | 14:13 |
| rafaelweingartner | Should we consider that as a sign to start removing support for Monasca? | 14:14 |
| mkarpiarz | Maybe no one is using this collector? | 14:14 |
| rafaelweingartner | that is what I assumed | 14:14 |
| priteau | At StackHPC we have migrated all our customer deployments away from it | 14:16 |
| rafaelweingartner | Can we agree to move on with the deprecation notice on Antelope? | 14:18 |
| rafaelweingartner | And then, removal on B release? | 14:18 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Announce future deprecation of Elasticsearch https://review.opendev.org/c/openstack/cloudkitty/+/864412 | 14:18 |
| priteau | Agreed. | 14:19 |
| rafaelweingartner | Ok | 14:19 |
| priteau | If someone wanted it back it wouldn't be too hard to bring back, unless we made major changes to the collector interface | 14:19 |
| rafaelweingartner | I will conduct that process then | 14:19 |
| priteau | Thank you. I propose a note for Elasticsearch. | 14:20 |
| rafaelweingartner | Thanks! | 14:20 |
| rafaelweingartner | Then, movin on with the meeting | 14:20 |
| rafaelweingartner | #topic Target review of the meeting | 14:20 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/861908 | 14:20 |
| rafaelweingartner | The gnocchi support matter | 14:21 |
| rafaelweingartner | have you guys read that patch? | 14:21 |
| rafaelweingartner | That is a serious issue in Gnocchi that we have known for a log time. However, it was a bit hard for us to get the patch merged upstream in Gnocchi | 14:21 |
| rafaelweingartner | and now, it is time for CloudKitty to use Gnocchi correctly | 14:21 |
| priteau | Looking now | 14:22 |
| rafaelweingartner | The problem is that it is backwards incompatible. As soon as we add that to Cloudkitty, all people using gnocchi have to update it | 14:22 |
| mkarpiarz | Yeah, that's my main concern (see my comment under the patch). | 14:23 |
| priteau | What happens if you pass the arg in a request to old Gnocchi? | 14:23 |
| priteau | Does it ignore it or deny the request? | 14:23 |
| priteau | If it doesn't work (i.e. fails the request) with old gnocchi, I think this should be behind a feature flag | 14:24 |
| priteau | i.e. an collector configuration option to enable use_history | 14:25 |
| priteau | Default of false for now, and we change it to true in a few releases | 14:25 |
| mkarpiarz | I agree. | 14:25 |
| priteau | This is what other projects would do :) | 14:25 |
| rafaelweingartner | it just ignores the parameter | 14:26 |
| rafaelweingartner | I mean, Gnocchi will ignore the parameter, and might return incosistent data | 14:27 |
| priteau | But will it be the same behaviour as before using use_history? | 14:27 |
| priteau | i.e. broken before this patch, and broken in exactly the same way after? | 14:28 |
| priteau | (if you are using old gnocchi) | 14:28 |
| rafaelweingartner | exactly | 14:28 |
| rafaelweingartner | use_history=false will produce the exact same behvior | 14:28 |
| rafaelweingartner | it is the same code that is exeuted when the use_history=false | 14:29 |
| rafaelweingartner | which is the default, when it is not used | 14:29 |
| priteau | In that case I think we can go ahead with this change and just document the Gnocchi dependency in the collector docs when it is released | 14:30 |
| priteau | Please add a release note bug fix though. | 14:30 |
| rafaelweingartner | ok | 14:30 |
| rafaelweingartner | I will do so then | 14:31 |
| rafaelweingartner | thanks! | 14:31 |
| priteau | Is there a test we can have in tempest for this? | 14:31 |
| rafaelweingartner | not that I am aware of | 14:32 |
| rafaelweingartner | tempest is using old Gnocchi versions | 14:32 |
| priteau | But the test could be marked as known to be failing | 14:35 |
| rafaelweingartner | hmm | 14:35 |
| priteau | And then when we would run it against new gnocchi we would see that it is working | 14:36 |
| rafaelweingartner | but I guess they are not testing this specific use case | 14:36 |
| priteau | This is mostly to catch a possible regression | 14:36 |
| rafaelweingartner | ah, I see | 14:36 |
| priteau | Don't worry if this is too complex | 14:36 |
| rafaelweingartner | I never created a tempest test | 14:36 |
| rafaelweingartner | I can try to see how to create it, and then create this test case | 14:36 |
| priteau | I don't think I've read much of our tempest plugin, I am not sure what we test | 14:38 |
| priteau | It would be a good effort to learn more about it and improve if needed | 14:38 |
| mkarpiarz | Definitely! | 14:39 |
| rafaelweingartner | exactly | 14:39 |
| rafaelweingartner | I will try to add it here then as well | 14:39 |
| rafaelweingartner | Are we done with this Gnocchi topic? Or, do you guys have something else to add? | 14:40 |
| priteau | Nothing else | 14:41 |
| rafaelweingartner | So, moving on | 14:41 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/861806 | 14:41 |
| rafaelweingartner | I alwaready reviewed that patch, and it is in a good shapre. However, it is important for you guys to review as well | 14:42 |
| rafaelweingartner | "alwaready" -> "already" | 14:43 |
| rafaelweingartner | "shapre" -> "shape" | 14:43 |
| mkarpiarz | I'm using this patch in my test environment and so far I see no issues. | 14:44 |
| rafaelweingartner | cool | 14:45 |
| mkarpiarz | Except for that missing metric I mentioned in a comment. | 14:45 |
| rafaelweingartner | we are already using it as well | 14:45 |
| priteau | What I don't really understand with this patch is whether it is Gnocchi-specific or if it would be useful for Prometheus too | 14:48 |
| priteau | mkarpiarz: you've used both systems, could you advise? | 14:49 |
| rafaelweingartner | useful for others | 14:49 |
| rafaelweingartner | That is a new concept we are introducing to enable operators to re-use a metric for different cloudkitty ratings | 14:49 |
| priteau | Shouldn't we implement it as collector-agnostic then? | 14:50 |
| rafaelweingartner | yes, and no. We only had the need for Gnocchi, and each collector needs to access some context objects. Therefore, we did not want to change the others, and right now they will not support it | 14:51 |
| rafaelweingartner | but the idea is to introduce that concept, and then if that is interesting for others, we can add to other collectors | 14:52 |
| priteau | I would just like to make sure we can provide the same capability for other collectors without changing the interface | 14:54 |
| rafaelweingartner | exactly, we did not change the collector interface | 14:54 |
| rafaelweingartner | that is why we did this way | 14:54 |
| rafaelweingartner | I would say that this is possible with other collectors as well | 14:54 |
| rafaelweingartner | At the end of the day, we are just collecting the metric again | 14:55 |
| rafaelweingartner | the only thing is that we have a different alt-name a group by and metadata sections | 14:55 |
| priteau | Let's go with it then | 14:57 |
| priteau | We have the whole release cycle to change the approach if needed | 14:57 |
| mkarpiarz | OK | 14:58 |
| rafaelweingartner | cool | 14:58 |
| rafaelweingartner | Well, we are running out of time | 14:58 |
| rafaelweingartner | I will open the floor for general questions now | 14:59 |
| rafaelweingartner | #topic Open floor moment | 14:59 |
| rafaelweingartner | Do you guys have something else do add to the meeting? | 14:59 |
| priteau | None from me | 15:00 |
| mkarpiarz | I would like to mention my message about v1 docs: | 15:00 |
| mkarpiarz | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031147.html | 15:00 |
| rafaelweingartner | Yes, I saw the message, but I have not read it yet | 15:00 |
| mkarpiarz | That's fine. We can discuss this one on through the mailing list. | 15:01 |
| rafaelweingartner | ok | 15:01 |
| rafaelweingartner | deal | 15:01 |
| mkarpiarz | I just wanted to make sure you guys are aware of it. :) | 15:01 |
| rafaelweingartner | :) | 15:01 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 15:01 |
| rafaelweingartner | #endmeeting | 15:02 |
| opendevmeet | Meeting ended Mon Nov 14 15:02:07 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-14-14.04.html | 15:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-14-14.04.txt | 15:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-14-14.04.log.html | 15:02 |
| priteau | Thanks, good bye! | 15:02 |
| mkarpiarz | Bye! | 15:03 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Use correct metadata for metrics gathered from gnocchi https://review.opendev.org/c/openstack/cloudkitty/+/861908 | 15:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!