| rafaelweingartner | Hello guyes | 14:00 |
|---|---|---|
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon May 2 14:00:42 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| priteau | Hello rafaelweingartner | 14:00 |
| rafaelweingartner | Hello Pierre | 14:01 |
| priteau | I believe it will be just the two of us today | 14:02 |
| rafaelweingartner | exactly | 14:03 |
| rafaelweingartner | OpenInfra Summit Berlin 2022 | 14:03 |
| rafaelweingartner | #topic OpenInfra Summit Berlin 2022 | 14:04 |
| rafaelweingartner | One of my CloudKitty presentations was accepted! Also, I suggest you guys to attend the event, it will be great opportunity to meet the OpenStack community. We also proposed two forum sessions, but we are not sure if they both will be accepted. | 14:04 |
| rafaelweingartner | Pierre: do you know when the results will be released? | 14:04 |
| priteau | I don't know :( I haven't heard anything either | 14:04 |
| priteau | We're just a month away now, it would be good to know | 14:04 |
| rafaelweingartner | exactly | 14:05 |
| rafaelweingartner | I can try to reach the organizers, to see when the rsults will be posted | 14:05 |
| priteau | You know what, I will drop an email to Kendall | 14:05 |
| rafaelweingartner | ok, thanks | 14:05 |
| rafaelweingartner | moving on | 14:08 |
| rafaelweingartner | #topic Target reviews | 14:08 |
| rafaelweingartner | We have the following patches as target for this meeting. | 14:10 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/830375 | 14:11 |
| rafaelweingartner | This one looks good to be merged | 14:11 |
| rafaelweingartner | Pierre, what do you think? It is yours. Should we wait for Mairusz? | 14:11 |
| rafaelweingartner | I guess we can merge it, as other people reviewed as well, and gave their +! | 14:14 |
| rafaelweingartner | +1 | 14:14 |
| priteau | Let's merge. We can always revert if Mariusz has concerns | 14:16 |
| priteau | We are at the beginning of the release cycle so it isn't a problem. | 14:17 |
| rafaelweingartner | The next one, #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/838062 | 14:17 |
| rafaelweingartner | it was already merged | 14:17 |
| rafaelweingartner | The next, #link https://review.opendev.org/c/openstack/cloudkitty/+/832923 | 14:18 |
| rafaelweingartner | it was also already merged | 14:18 |
| rafaelweingartner | my bad, this #link https://review.opendev.org/c/openstack/cloudkitty/+/832923, was not merged yet | 14:18 |
| rafaelweingartner | I reviewed it, and it seems to be ok to be merged | 14:19 |
| rafaelweingartner | we are only waiting for other people to review it | 14:19 |
| rafaelweingartner | The same is valid for #link https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:20 |
| priteau | About "Include /v2 in public routes for keystone auth" | 14:20 |
| priteau | Is it a bug fix? What does it change in practice? | 14:21 |
| rafaelweingartner | what do you mean? | 14:21 |
| rafaelweingartner | it adds the v2 to the skip list of endpoints | 14:21 |
| rafaelweingartner | meaning, that we do not need to authenticate to call it | 14:22 |
| rafaelweingartner | to follow the pattern we have for /v1, and /healthcheck | 14:22 |
| priteau | It's just the top endpoint, i.e. /v2? not /v2/something? | 14:23 |
| priteau | Sorry, I am not really familiar with api-paste | 14:23 |
| rafaelweingartner | exactly | 14:26 |
| rafaelweingartner | just the /v2, and not the /v2/....otherAPIs... | 14:27 |
| priteau | Should we change https://opendev.org/openstack/cloudkitty/src/branch/master/cloudkitty/tests/gabbi/gabbi_paste.ini too? | 14:28 |
| rafaelweingartner | I would say that we do not need | 14:29 |
| rafaelweingartner | as it is replacing the default | 14:29 |
| rafaelweingartner | but, if we want to use it as the default, I think that we can then suggest the author to also add this change to it | 14:30 |
| rafaelweingartner | that will be interesting, when we add more functional tests to V2 API | 14:31 |
| rafaelweingartner | which we do not have right now | 14:31 |
| rafaelweingartner | I guess, we can then discuss it further with the author | 14:34 |
| priteau | Approved | 14:34 |
| rafaelweingartner | Moving on, we have the following patches that were created by me: #link https://review.opendev.org/c/openstack/cloudkitty/+/837442, and #link https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 14:36 |
| rafaelweingartner | I am waiting for reviews, and feedbacks | 14:36 |
| rafaelweingartner | one is a bug fix, and the other is an extension | 14:36 |
| priteau | I am looking at the cost precision one | 14:40 |
| rafaelweingartner | ok, thanks! | 14:41 |
| priteau | Did we actually cause a regression in https://review.opendev.org/c/openstack/cloudkitty/+/755865? | 14:42 |
| priteau | Numeric used to be configured with 20, 8 and we moved to 30, 28 | 14:42 |
| priteau | Does this mean that before this patch, we were able to use costs with 12 digits, but not after? | 14:43 |
| rafaelweingartner | exactly | 14:44 |
| rafaelweingartner | I was thinkig about that, should we add support for 12 digits? | 14:44 |
| rafaelweingartner | I felt too much, that is why I just add 31 | 14:45 |
| priteau | I think so. Three digits seems arbitrarily low | 14:45 |
| rafaelweingartner | ok | 14:46 |
| rafaelweingartner | I will amend it then | 14:46 |
| priteau | Is it likely to cause big performance impact? | 14:47 |
| rafaelweingartner | I don't think so | 14:47 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Allow rating rules that have three digits in the integer part of the number https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 14:51 |
| rafaelweingartner | I will use 40/28 then | 14:51 |
| priteau | I think some operators may want to use integer costs and that can quickly rise | 14:51 |
| priteau | Thanks | 14:51 |
| rafaelweingartner | and this will allow the same number of integers as before | 14:51 |
| priteau | So that would allow 999,999,999,999 in the integer part? | 14:51 |
| rafaelweingartner | exactly | 14:52 |
| priteau | Now that should be plenty | 14:52 |
| priteau | We shouldn't backport it though, as that could cause issues with DB migrations and people doing upgrades | 14:53 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 14:53 |
| rafaelweingartner | yes | 14:53 |
| rafaelweingartner | I agree | 14:53 |
| priteau | The changes in cloudkitty/dataframe.py are something else? | 14:54 |
| rafaelweingartner | yes, and no | 14:55 |
| rafaelweingartner | they were needed due to some library update | 14:55 |
| priteau | I see | 14:55 |
| rafaelweingartner | then, when I did the patching, I had to fix that as wel | 14:55 |
| rafaelweingartner | should I separate it? | 14:55 |
| priteau | No, it's ok | 14:57 |
| rafaelweingartner | We are running out of time, but I also created these two patches: #link https://review.opendev.org/c/openstack/python-cloudkittyclient/+/839052, and #link https://review.opendev.org/c/openstack/python-cloudkittyclient/+/838724 | 14:57 |
| rafaelweingartner | they are inteded to add these new developments into CloudKitty CLI | 14:57 |
| rafaelweingartner | It would be interesting to review them as well | 14:58 |
| priteau | Thanks, I will review when time allows | 14:58 |
| rafaelweingartner | awesome thanks! | 14:58 |
| rafaelweingartner | I guess we can close for today then :) | 14:58 |
| rafaelweingartner | do you have something to add? | 14:58 |
| priteau | Nothing more | 14:59 |
| priteau | Actually just one small thing | 14:59 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:59 |
| rafaelweingartner | shoot :) | 14:59 |
| priteau | Please review https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/839903 | 14:59 |
| rafaelweingartner | sure | 14:59 |
| rafaelweingartner | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Mon May 2 15:00:29 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-05-02-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-05-02-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-05-02-14.00.log.html | 15:00 |
| opendevreview | Merged openstack/cloudkitty-dashboard master: Address RemovedInDjango40Warning https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/839903 | 15:11 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 18:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!