| jonher | hey, i was checking the documentation but couldn't find how to add a resource like: ip.floating it's of type "network" according to metrics but the "network" resource-type is blank (at least with OSA), do you know of a page that has this documented or explains the relation? | 13:46 |
|---|---|---|
| rafaelweingartner | what is OSA | 13:56 |
| rafaelweingartner | this is normally not related to CloudKitty, but to Gnocchi | 13:56 |
| rafaelweingartner | and ceilometer | 13:57 |
| rafaelweingartner | if a resource-type does not exist, you can create it | 13:57 |
| rafaelweingartner | if the attributes you want do not exist, you can modify a resource type to have more attributes | 13:57 |
| rafaelweingartner | and then, just then, they will be available to cloudkitty | 13:57 |
| rafaelweingartner | therefore, it is not something that you configure in CloudKitty | 13:57 |
| rafaelweingartner | CloudKitty only consumes/uses data/information available in Gnocchi | 13:57 |
| rafaelweingartner | or other storage backend | 13:58 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Nov 29 14:00:00 2021 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| rafaelweingartner | Hello priteau: | 14:01 |
| priteau | Hello | 14:01 |
| rafaelweingartner | I just started the meeting | 14:01 |
| priteau | Sorry, IRC bouncer has died | 14:01 |
| rafaelweingartner | I was meeting for the roll count | 14:01 |
| rafaelweingartner | I was waiting for the roll count responses** | 14:01 |
| mkarpiarz | Hi! | 14:02 |
| rafaelweingartner | Hello mkarpiarz! | 14:03 |
| rafaelweingartner | I guess we can start with the target reviews of the meeting | 14:03 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/774520 | 14:04 |
| rafaelweingartner | priteau: there was a request from you there. Is this patch missing something else? | 14:04 |
| priteau | Checking | 14:04 |
| rafaelweingartner | awesome, thanks | 14:05 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/792090 | 14:05 |
| rafaelweingartner | mkarpiarz: were you able to check that patch? | 14:05 |
| mkarpiarz | Not yet, sorry. | 14:06 |
| mkarpiarz | I was having problems with making pyscripts work in my test environment and no time to get to the bottom of it. | 14:07 |
| priteau | Small doc syntax comment on the first | 14:07 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Introduce "response_format" for the V2 summary API https://review.opendev.org/c/openstack/cloudkitty/+/774520 | 14:12 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Introduce "response_format" for the V2 summary API https://review.opendev.org/c/openstack/cloudkitty/+/774520 | 14:13 |
| rafaelweingartner | priteau: I fixed the issue in the first patch | 14:15 |
| priteau | THanks | 14:15 |
| rafaelweingartner | do you guys think that we can merge it, as soon as the tests pass? | 14:15 |
| priteau | Yes for me | 14:16 |
| rafaelweingartner | ok | 14:16 |
| priteau | I'll just check the output of the doc generation | 14:16 |
| rafaelweingartner | Mariusz had already tested, and approved that one | 14:16 |
| rafaelweingartner | Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/792090 | 14:16 |
| rafaelweingartner | should we wait for Mariusz tests? Or, maybe, can we move on ans merge this one | 14:17 |
| mkarpiarz | I think this change can be merged safely, regardless of my tests. | 14:18 |
| rafaelweingartner | Ok, I will merge it then | 14:18 |
| priteau | +1 | 14:19 |
| rafaelweingartner | Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 14:19 |
| rafaelweingartner | we reviewed this patch, and the author was not responding | 14:19 |
| rafaelweingartner | I then, reached the author, and he said that he was going to address our reviews | 14:20 |
| rafaelweingartner | however, almost two months have gone by, and still we do not have an answer | 14:20 |
| rafaelweingartner | should we take over the patch? And execute the improvents ourselves? | 14:21 |
| priteau | I will check if I can see it in some of our deployments | 14:22 |
| priteau | I've seen the issue before but that environment must have been upgraded since | 14:22 |
| rafaelweingartner | ok | 14:23 |
| rafaelweingartner | I will mark it as yours, I mean, as the person investigating and maybe improving it | 14:23 |
| rafaelweingartner | then, we can discuss it again during our next meeting | 14:23 |
| rafaelweingartner | and, finally the last one | 14:24 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/777442 | 14:24 |
| rafaelweingartner | priteau: you requested some changes that were addressed | 14:24 |
| rafaelweingartner | do you have something else to add there? Or, maybe, can we move on and merge it | 14:24 |
| priteau | Merged | 14:27 |
| rafaelweingartner | awesome, thanks | 14:29 |
| rafaelweingartner | do you guys have any other priority for our next meeting? | 14:30 |
| priteau | zigo's patch | 14:31 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty/+/814789 | 14:31 |
| zigo | priteau: What don't you understand ? | 14:32 |
| rafaelweingartner | ok | 14:32 |
| rafaelweingartner | I will add for our next meeting | 14:32 |
| rafaelweingartner | Zigo: why using "W: ...." in the log message | 14:32 |
| rafaelweingartner | I missed that during my review | 14:33 |
| mkarpiarz | I think W=warning | 14:33 |
| rafaelweingartner | that is not the proper way | 14:33 |
| zigo | W stands for Warning, I can either remove it or write warning in full. | 14:33 |
| zigo | Let me know what you decide. | 14:33 |
| priteau | That's not really standard | 14:33 |
| rafaelweingartner | LOG.warning'( | 14:33 |
| rafaelweingartner | LOG.debug = for debug | 14:33 |
| rafaelweingartner | LOG.warning = for warning | 14:33 |
| priteau | I just grepped through most openstack projects and no LOG statements are using this | 14:33 |
| zigo | Well, I still think LOG.debug is the way... | 14:33 |
| rafaelweingartner | LOG.info = for general information | 14:33 |
| rafaelweingartner | and so on | 14:33 |
| zigo | It will print too much otherwise. | 14:33 |
| zigo | So I can just remove the "W:" then. | 14:34 |
| priteau | I think you can just remove W" | 14:34 |
| rafaelweingartner | if it is a debug message, therefore it is not warning | 14:34 |
| rafaelweingartner | so, no need for the W | 14:34 |
| priteau | The message is good enough | 14:34 |
| rafaelweingartner | +1 | 14:34 |
| zigo | There you go ! | 14:34 |
| opendevreview | Thomas Goirand proposed openstack/cloudkitty master: Adding two options in fetcher_keystone https://review.opendev.org/c/openstack/cloudkitty/+/814789 | 14:34 |
| zigo | Please review ... :) | 14:34 |
| priteau | Just left another comment | 14:35 |
| rafaelweingartner | anyways, we can finish this patch review in our next meeting, and execute the review rounds in an async fashion | 14:35 |
| zigo | priteau: Done. | 14:36 |
| opendevreview | Thomas Goirand proposed openstack/cloudkitty master: Adding two options in fetcher_keystone https://review.opendev.org/c/openstack/cloudkitty/+/814789 | 14:36 |
| rafaelweingartner | besides this patch, do you guys have any other priority? | 14:36 |
| mkarpiarz | Nothing from my side. | 14:37 |
| rafaelweingartner | Otherwise, I will grab the ones I find most promissing, or almost ready for our next meeting | 14:37 |
| zigo | Internally, we added an index in the rated_dataframe, it'd be nice if it was added upstream too. | 14:37 |
| rafaelweingartner | your patch would be welcome :) | 14:37 |
| zigo | Though I don't think we / I have enough skills to do that with SQLAlchemy. | 14:37 |
| zigo | If anyone can show me how, I'll do it. | 14:37 |
| zigo | (an example somewhere ?) | 14:38 |
| zigo | We went from 23 seconds per query to 0.03 with the index, so it's quite important ! | 14:38 |
| zigo | (millions of records...) | 14:38 |
| rafaelweingartner | can you open a bug report? | 14:38 |
| zigo | Sure ! | 14:39 |
| rafaelweingartner | then, we can move on from there | 14:39 |
| zigo | Thanks. | 14:39 |
| rafaelweingartner | and maybe, I can create the patch | 14:39 |
| rafaelweingartner | And now, for the final minutes, I will open to general/open issues/questions that one might have | 14:39 |
| rafaelweingartner | #topic AOB | 14:40 |
| zigo | In Storyboard, right? | 14:40 |
| rafaelweingartner | zigo: yes | 14:40 |
| zigo | One more thing I'd like to discuss. | 14:40 |
| zigo | We have our billing system querying Cloudkitty for each project one by one, each hours. | 14:41 |
| zigo | Though we don't know if a project has finished to be rated for the queried hour ... | 14:41 |
| zigo | Shouldn't that be exposed to the API ? | 14:41 |
| rafaelweingartner | you can check the latest processing state of the project | 14:42 |
| rafaelweingartner | https://review.opendev.org/c/openstack/cloudkitty/+/774634 | 14:42 |
| rafaelweingartner | last_processed_timestamp will be marked with the timestamp of the last processed timestamp | 14:43 |
| zigo | Oh, thanks. | 14:43 |
| zigo | We're using Victoria in production, which is why we don't have this... | 14:43 |
| zigo | I'll backport the patch, that's very helpful, thanks again. | 14:43 |
| rafaelweingartner | welcome | 14:45 |
| rafaelweingartner | I had an issue with my Internet connection | 14:50 |
| rafaelweingartner | so, I guess that we can close for now, right? | 14:50 |
| rafaelweingartner | do you guys have something else to add | 14:50 |
| rafaelweingartner | ? | 14:50 |
| priteau | Nothing from me | 14:51 |
| mkarpiarz | I'm good too. | 14:52 |
| rafaelweingartner | Ok | 14:52 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:52 |
| rafaelweingartner | #endmeeting | 14:52 |
| opendevmeet | Meeting ended Mon Nov 29 14:52:31 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:52 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-11-29-14.00.html | 14:52 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-11-29-14.00.txt | 14:52 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-11-29-14.00.log.html | 14:52 |
| mkarpiarz | Thanks, guys. | 14:53 |
| opendevreview | Merged openstack/cloudkitty master: Fixed PyScripts.start_script method to return the updated data object https://review.opendev.org/c/openstack/cloudkitty/+/792090 | 14:57 |
| opendevreview | Merged openstack/cloudkitty master: Add active status fields in the storage state table https://review.opendev.org/c/openstack/cloudkitty/+/777442 | 15:07 |
| *** sboyron__ is now known as sboyron | 15:42 | |
| *** sboyron is now known as Guest7150 | 15:43 | |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Adding two options in fetcher_keystone https://review.opendev.org/c/openstack/cloudkitty/+/814789 | 21:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!