| kevko | priteau: Hi, thanks for review :), but I want to ask ..there is another CI block issue [cloudkitty] >> LookupError: 'invalid' is not among the defined enum values. Enum name: enum_map_type. Possible values: flat, rate | 07:05 |
|---|---|---|
| kevko | could you help ? i think it has to have something with oslo.db or sqlalchemy version | 07:06 |
| kevko | priteau: i think this should raise exception exception.DBError if I understand code correctly -> https://github.com/openstack/cloudkitty/blob/510d8bf564e61bc3439c687f82919eb43e826b3e/cloudkitty/rating/hash/db/sqlalchemy/api.py#L314 | 07:08 |
| priteau | kevko: good morning. yes, there is another CI blocker, I have a WIP patch | 07:43 |
| kevko | priteau: really ? can u commit to gerrit so I can Depends-On that ? | 07:43 |
| priteau | It all needs to be in the same commmit | 07:44 |
| priteau | You can't merge patches if CI is not fully green | 07:44 |
| kevko | priteau: yes, I know ..but my patch -> https://review.opendev.org/c/openstack/cloudkitty/+/797323 is fixing one issue ..and If i depends on to that one with 'invalid ' | 07:45 |
| kevko | ah, yeah ..i got it | 07:45 |
| priteau | I'll take care of it | 07:46 |
| kevko | so, could you upgrade my patch ? or share your findings ? | 07:46 |
| priteau | Yes I am on it :P | 07:46 |
| kevko | priteau: point is that i really want to have https://review.opendev.org/c/openstack/cloudkitty/+/797313 green, so I can patch debian package for cloudkitty as it's not working in wallaby currently ...and want to be sure that patch will pass CI | 07:47 |
| priteau | It will be ready in a few minutes | 07:50 |
| priteau | By the way Depends-On is really designed for inter-repository dependencies. For dependencies in the same repository, you can just stack your patches on top of each other in Git | 07:51 |
| kevko | ah, ok, got it | 07:56 |
| kevko | so, when it will be ready, i can just rebase on top of it, right ? | 07:57 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Fix code broken by SQLAlchemy 1.4 https://review.opendev.org/c/openstack/cloudkitty/+/797323 | 07:59 |
| priteau | yes | 08:00 |
| priteau | ready, I think | 08:00 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Fix code broken by SQLAlchemy 1.4 https://review.opendev.org/c/openstack/cloudkitty/+/797323 | 08:03 |
| kevko | thank you | 08:45 |
| kevko | done | 08:48 |
| opendevreview | Michal Arbet proposed openstack/cloudkitty master: Fix cloudkitty exception handling from gnocchiclient https://review.opendev.org/c/openstack/cloudkitty/+/797313 | 08:49 |
| opendevreview | Michal Arbet proposed openstack/cloudkitty master: Fix cloudkitty exception handling from gnocchiclient https://review.opendev.org/c/openstack/cloudkitty/+/797313 | 09:55 |
| *** ChanServ changes topic to "Rating component for OpenStack https://wiki.openstack.org/wiki/CloudKitty" | 12:30 | |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: SQLalchemy not creating constraint for Enum on version 1.4.0+ https://review.opendev.org/c/openstack/cloudkitty/+/797443 | 12:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!