| *** vishalmanchanda has joined #cloudkitty | 04:54 | |
| *** sboyron has joined #cloudkitty | 06:12 | |
| *** cylopez has joined #cloudkitty | 07:40 | |
| openstackgerrit | Jonathan Herlin proposed openstack/cloudkitty-dashboard master: Respect endpoint type specificed in horizon https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/789278 | 12:56 |
|---|---|---|
| jonher | ^ had the issue of cloudkitty dashboard always using the publicURL even if horizon was set to use only "internal", commit above fixes that and now inherits the option from horzion settings like https://github.com/openstack/octavia-dashboard/blob/master/octavia_dashboard/api/rest/lbaasv2.py#L50 does it | 12:58 |
| jonher | i tested this in OpenStack Ansible AIO, before the fix it would fail on SSL against public endpoint, after fix it would connect to internal http endpoint and show the dashboard like expected | 13:09 |
| priteau | Hi jonher, thanks a lot for the fix. | 13:54 |
| jonher | no problem at all :) hopefully someone has time to review the changes open | 14:07 |
| priteau | jonher: Code change looks OK, I fixed a few typos in the commit message. The change itself needs a release note though and it would be nice to have a story/task in storyboard. Would you be able to add these? | 14:12 |
| openstackgerrit | Pierre Riteau proposed openstack/cloudkitty-dashboard master: Respect endpoint type specified in Horizon https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/789278 | 14:13 |
| priteau | ^ just commit message changes | 14:14 |
| jonher | i'll create a story in storyboard and create a reno releasenote linked to it | 14:17 |
| priteau | Thank you | 14:25 |
| openstackgerrit | Jonathan Herlin proposed openstack/cloudkitty-dashboard master: Respect endpoint type specified in Horizon https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/789278 | 14:28 |
| *** rafaelweingartne has joined #cloudkitty | 14:31 | |
| jonher | first time using storyboard, but hopefully it looks ok. reno releasenote is pushed too | 14:31 |
| jonher | https://storyboard.openstack.org/#!/story/2008879 | 14:31 |
| jonher | do you link to the sotryboard item in the commit message or how is it usually done? | 14:31 |
| *** rafaelweingartne has quit IRC | 14:32 | |
| *** cylopez has quit IRC | 14:50 | |
| priteau | jonher: you add story and task to the commit message, like this: https://review.opendev.org/c/openstack/cloudkitty/+/773954 | 14:52 |
| priteau | See https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references | 14:52 |
| jonher | thanks, that was new for me | 14:58 |
| openstackgerrit | Jonathan Herlin proposed openstack/cloudkitty-dashboard master: Respect endpoint type specified in Horizon https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/789278 | 14:58 |
| priteau | jonher: one minor note, you named the reno "keystone-entrypoint-type", did you mean "keystone-endpoint-type"? | 15:38 |
| jonher | doh, yes... working with docker at the same time so that slipped thru, fixing | 15:40 |
| openstackgerrit | Jonathan Herlin proposed openstack/cloudkitty-dashboard master: Respect endpoint type specified in Horizon https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/789278 | 15:40 |
| *** vishalmanchanda has quit IRC | 19:13 | |
| *** priteau has quit IRC | 19:54 | |
| *** priteau has joined #cloudkitty | 19:55 | |
| *** sboyron has quit IRC | 20:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!