Monday, 2021-01-25

*** jopdorp has quit IRC00:18
*** jopdorp_ has joined #cloudkitty00:18
*** vishalmanchanda has joined #cloudkitty06:09
*** sboyron has joined #cloudkitty08:39
*** sboyron has quit IRC12:16
*** sboyron has joined #cloudkitty12:17
*** mkarpiarz has joined #cloudkitty13:27
*** rafaelweingartne has joined #cloudkitty13:55
rafaelweingartne#startmeeting cloudkitty14:00
openstackMeeting started Mon Jan 25 14:00:38 2021 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartne. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: cloudkitty)"14:00
openstackThe meeting name has been set to 'cloudkitty'14:00
rafaelweingartneHello guys14:00
rafaelweingartneRoll count14:00
priteauo/14:01
mkarpiarzHi!14:03
rafaelweingartne:)14:03
rafaelweingartne#topic Review priorities14:05
*** openstack changes topic to "Review priorities (Meeting topic: cloudkitty)"14:05
rafaelweingartneDo you guys have some review priorities?14:05
rafaelweingartneAt least, from my side, I do not have any so far14:05
priteauI'll look at the policy patch, it's one of the priorities for this cycle.14:06
mkarpiarzI can do testing of changes to the v2 API once I wrap my head around how v2 API works. :)14:07
rafaelweingartneI am mistaken, I would have some priorities14:08
rafaelweingartne#link https://review.opendev.org/c/openstack/cloudkitty-specs/+/77092814:08
rafaelweingartne#link https://review.opendev.org/c/openstack/cloudkitty-specs/+/77151314:08
rafaelweingartneDid you have time to check them?14:08
mkarpiarzYeah, good shout on this one, rafaelweingartne.14:09
rafaelweingartneAs soon as I get your feedback on them there, and if we are ok with them. I could create the patches14:09
rafaelweingartneand maybe we can add these to Wallaby release as well14:09
mkarpiarzThere would need to be a change in database migration between releases, I imagine.14:11
rafaelweingartneexactly14:11
rafaelweingartneand specially for the state field deprecation14:12
mkarpiarzI'm totally onboard with this change and I feel like the name you suggested describes this column way better.14:13
mkarpiarz(but I've already given my +1 to this one)14:14
priteauI need to check the code but I think the last_processed_date is OK, although I'll have comments14:15
rafaelweingartneThanks for the review in both of them14:15
rafaelweingartnepriteau: I am open to suggestions14:15
priteauThe other one I am not so sure, I was hoping the fetcher could do something automatic14:15
rafaelweingartnethe last_processed_date was just what I came up with14:15
rafaelweingartnepriteau: we discussed that, but it is not so simple14:16
rafaelweingartneThere are some implication if we do that automatically, and we could always miss data, or create a situation that the system could be exploited14:17
mkarpiarzIt might be better to have an option to manually set projects as inactive rather than no such option at all.14:20
priteauOK, looking at the Gnocchi fetcher code, it is based on resource.list(). I thought that it was looking at metrics.14:22
priteauYour approach may be appropriate then14:24
rafaelweingartneThank you guys for your reviews!14:27
rafaelweingartneI will open for general questions and topics that people might have.14:28
rafaelweingartne#topic AOB14:28
*** openstack changes topic to "AOB (Meeting topic: cloudkitty)"14:28
priteauDo you want to discuss the mutators?14:29
rafaelweingartneIf you guys want, we do have time for it14:30
mkarpiarzSure. Is there anything you want to discuss?14:31
mkarpiarzThere are no changes yet but I belive we've agreed to going the "function mappings" route for now.14:32
mkarpiarzUnless you guys are comfortable with using eval() with custom strings for defining mutators.14:33
priteauI think it's best to avoid if we can get away with something well defined14:33
mkarpiarzI agree.14:34
priteauEven for ease of use. Get the function a bit wrong and you get exceptions in CloudKitty14:35
mkarpiarzHowever mapping allowed strings to allowed mutators is already done in the code.14:36
mkarpiarzGranted, we could move all the mutators to a dict and add more of them, especially the negating mutator.14:36
mkarpiarzOr maybe we should let users chain basic mutators together so they can create more complex functions this way?14:38
rafaelweingartneDo we have use cases for that?14:39
rafaelweingartneIf not, I would not go down that road14:39
mkarpiarzWell, the main usecase is the Prometheus one.14:41
mkarpiarzWhere 0 in openstack_nova_server_status denotes instances that are active.14:42
rafaelweingartnehmm for chained mutators?14:43
mkarpiarzWell, if we let users chain mutator they could chain NOT with the NUMBOOL for this. :)14:44
rafaelweingartneI mean, is there a current use case for Prometheus where one needs to retrieve some data, and then pass it through different mutators?14:44
rafaelweingartneI see14:44
mkarpiarzBut the same can easier if we introduce a "NOT NUMBOOL" mutator14:46
mkarpiarzwhich returns 1 when the measurement is a zero and 0 otherwise.14:48
rafaelweingartneI see14:49
rafaelweingartnewe do not actually use mutators, but I can see where you are using it14:49
mkarpiarzBut then what if someone wants to bill shut down instances but not these in error state?14:49
rafaelweingartneWe use the dynamic pollster for that14:50
rafaelweingartnewe map the states to either 0 or 114:50
rafaelweingartneand then we create a metric on Gnocchi with these, and this metric that has either 0 or 1 is rated by Cloudkitty14:50
rafaelweingartnewe do this for octavia, VPN, and other resources as well14:50
mkarpiarzAh, nice!14:51
rafaelweingartneThat is why we do not use the mutators14:51
rafaelweingartneCloudKitty receives that data already prepared and processed, and it only has to rate it14:51
rafaelweingartneWe do know that Ceilometer removed the binary that collection pollsters, but the dynamic pollsters is generic :)14:52
mkarpiarzI've no idea if it's possible to tell Prometheus to convert values it returns to bools before submitting them but I'll check.14:52
rafaelweingartnetherefore, the operators create their own using YAML14:52
rafaelweingartnedata collection pollsters*14:53
rafaelweingartneguys, I gotta go now14:56
rafaelweingartneThank you guys for participating. Have a nice week.14:56
priteauThanks both14:56
priteauBye!14:56
rafaelweingartneIf you need anything from me, just ping14:56
rafaelweingartne#endmeeting14:56
mkarpiarzThanks and bye!14:56
*** openstack changes topic to "Rating component for OpenStack https://wiki.openstack.org/wiki/CloudKitty"14:56
openstackMeeting ended Mon Jan 25 14:56:54 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:56
openstackMinutes:        http://eavesdrop.openstack.org/meetings/cloudkitty/2021/cloudkitty.2021-01-25-14.00.html14:56
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/cloudkitty/2021/cloudkitty.2021-01-25-14.00.txt14:56
openstackLog:            http://eavesdrop.openstack.org/meetings/cloudkitty/2021/cloudkitty.2021-01-25-14.00.log.html14:56
*** rafaelweingartne has quit IRC14:57
*** vishalmanchanda has quit IRC15:18
openstackgerritRafael Weingartner proposed openstack/cloudkitty-specs master: Add "active" column to storage scope, and API to manage it  https://review.opendev.org/c/openstack/cloudkitty-specs/+/77092816:21
openstackgerritRafael Weingartner proposed openstack/cloudkitty-specs master: Deprecate `state` field and propose `last_processed_date` field  https://review.opendev.org/c/openstack/cloudkitty-specs/+/77151316:24
*** sboyron has quit IRC17:56
*** sboyron has joined #cloudkitty17:57
*** irclogbot_0 has quit IRC18:46
*** irclogbot_3 has joined #cloudkitty18:49
*** sboyron has quit IRC21:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!