| *** logan- has quit IRC | 01:22 | |
| *** logan- has joined #ara | 01:23 | |
| *** logan- has quit IRC | 01:31 | |
| *** logan- has joined #ara | 01:31 | |
| *** bcoca has quit IRC | 01:36 | |
| dmsimard | gvincent, apollo13: This would never get exercised by the callback plugin because their creation are done in a chronological order: https://github.com/openstack/ara-server/blob/d3de8af4c8b6d95f4a2fb9f63f0d33ae276c1ae4/ara/api/serializers.py#L215-L230 | 02:47 |
|---|---|---|
| dmsimard | Meaning we currently do synchronous API calls as the callback hooks are received -- we would not realistically have all that data available at the time we currently create the playbook | 02:50 |
| dmsimard | Here we first create the playbook and then create the first file (the playbook file): https://github.com/openstack/ara-plugins/blob/7cf37ea15fd7959ba8507ac088510834116e32ce/ara/plugins/callback/ara_default.py#L138-L156 | 02:51 |
| dmsimard | I was going to suggest taking the unused part out but then it made me think that there might be alternative ways to send the data back to the API. | 02:53 |
| dmsimard | We would only ever exercise that kind of "feature" if we'd post once we have all the data | 02:56 |
| dmsimard | Which is... perhaps okay ? It depends on the cost of doing more small API calls vs one monstrous API call at the end. Even a 25ms roundtrip to the API adds up when you're dealing with thousands of hosts and tasks... :( | 02:57 |
| dmsimard | Anyway, I'll run some benchmarks to measure what is the current status so we can tell if we're improving things or making them worse | 02:59 |
| ara-slack | alwaysharsha: @alwaysharsha has joined the channel | 06:50 |
| *** themroc has joined #ara | 08:09 | |
| *** herald85 has joined #ara | 08:11 | |
| *** herald85 has quit IRC | 08:29 | |
| apollo13 | dmsimard: isn't it mainly a question of how much data you want to "loose" if ansible crashes in the middle | 08:55 |
| *** herald85 has joined #ara | 12:19 | |
| dmsimard | apollo13: yes, it's basically that state needs to be kept *somewhere* | 12:57 |
| *** themroc has quit IRC | 16:03 | |
| *** Arsenick has joined #ara | 16:10 | |
| *** herald85 has quit IRC | 16:47 | |
| *** etienne has quit IRC | 18:24 | |
| *** krion has quit IRC | 22:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!