| *** tristanC has quit IRC | 00:33 | |
| *** tristanC has joined #ara | 00:33 | |
| *** bcoca has quit IRC | 02:08 | |
| *** gvincent has joined #ara | 04:44 | |
| *** gvincent has quit IRC | 04:48 | |
| *** gvincent has joined #ara | 05:15 | |
| *** themurph has joined #ara | 11:44 | |
| *** themurph_ has joined #ara | 11:47 | |
| *** themurph has quit IRC | 11:49 | |
| *** bcoca has joined #ara | 12:56 | |
| *** themurph_ has quit IRC | 13:01 | |
| *** themurph has joined #ara | 13:04 | |
| *** tbielawa has joined #ara | 13:20 | |
| *** bcoca has quit IRC | 14:29 | |
| *** tbielawa is now known as tbielawa|demos | 14:43 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Expose the sha1 in the API file serializer https://review.openstack.org/607979 | 15:01 |
|---|---|---|
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Hash the files before compressing them https://review.openstack.org/607660 | 15:09 |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Expose the sha1 in the API file serializer https://review.openstack.org/607979 | 15:19 |
| *** sshnaidm is now known as sshnaidm|afk | 15:20 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara-plugins master: Update README.rst to be more accurate https://review.openstack.org/607281 | 15:25 |
| *** sshnaidm|afk is now known as sshnaidm | 15:36 | |
| *** themurph has quit IRC | 16:03 | |
| *** gvincent has quit IRC | 16:12 | |
| *** themurph has joined #ara | 16:48 | |
| *** tbielawa|demos is now known as tbielawa | 17:16 | |
| *** themurph has quit IRC | 17:18 | |
| *** Serienmorder has joined #ara | 17:24 | |
| apollo13 | dmsimard: not that I have much time left this week; but what would the next things be that you want to tackle on the server side? | 17:25 |
| *** tbielawa is now known as tbielawa|lunch | 17:33 | |
| dmsimard | apollo13: hey, the todo is here: https://etherpad.openstack.org/p/ara-todo-1.0 | 17:55 |
| dmsimard | apollo13: I'm not very good at doing the pagination and searching/filtering things, maybe it's something you could pick up | 17:56 |
| dmsimard | I think there is pagination right now but it's set to 1000 items or something which is not realistic | 17:56 |
| dmsimard | tristanC and I ran a fuzzer on the API and we could tell that the performance was dropping over time due to inefficient pagination | 17:57 |
| dmsimard | for searching and filtering, well, it's to be able to do things like "get tasks with status X", for example | 17:57 |
| apollo13 | sure, but I am not sure how you want to work against that | 17:57 |
| apollo13 | no matter what you do, if you use limit/offset based pagination you will get slower | 17:58 |
| apollo13 | the further you go down the pages the slower you get | 17:58 |
| apollo13 | after all the database has to run sort etc before and then go through the pages | 17:58 |
| dmsimard | sure | 17:58 |
| dmsimard | that's fine | 17:58 |
| dmsimard | but running GETs on 1000 items pages would be slower than running GETs on, say, 100 items per page | 17:59 |
| apollo13 | true | 17:59 |
| dmsimard | if we have 5000 playbooks in the database for example, we probably don't want the API to return 1000 per page on a GET to /playbooks | 17:59 |
| dmsimard | FWIW I put in place black and isort for ara-clients and ara-plugins, thanks again for that : | 18:00 |
| dmsimard | :) | 18:00 |
| apollo13 | jupp, saw the commits; nice work! | 18:00 |
| dmsimard | so yeah, I think proper pagination/search/filtering is a thing we need and that I'm not good at | 18:01 |
| apollo13 | that said I am still a bit lost with regards to pagination and filtering; the todo is rather vague. the default size of 1k is just a setting; so what exactly do you miss or want with sarch filtering? | 18:01 |
| dmsimard | apollo13: the pagination and searching/filtering that exists today comes from more or less a copy/paste from gvincent | 18:02 |
| dmsimard | so don't assume that anything currently implemented was done conciously | 18:02 |
| apollo13 | right, but what do you miss in terms of features etc? | 18:02 |
| apollo13 | I mean the defaults from DRF more or less just work ™ | 18:02 |
| dmsimard | apollo13: if you can do react, you can help on the web interface if you'd like :P | 18:04 |
| dmsimard | it's probably what needs the most work | 18:04 |
| apollo13 | I'll be doing js over my dead body | 18:04 |
| dmsimard | haha | 18:04 |
| dmsimard | I know the feeling, I tried and I gave up | 18:04 |
| apollo13 | I am a sysadmin at work, so guess my motivation to do js | 18:04 |
| apollo13 | :D | 18:04 |
| apollo13 | also vuejs if needs be | 18:04 |
| dmsimard | hmmm, the other thing is configuration/settings for the backend | 18:05 |
| dmsimard | I got the configuration for the callback figured out | 18:05 |
| dmsimard | I'm not sure what I want our settings.py to do yet | 18:05 |
| apollo13 | preferably fully configurable with env vars ;) | 18:06 |
| dmsimard | yeah, but not exclusively | 18:06 |
| dmsimard | ansible actually has something that lets plugins configure themselves through envvars and ansible.cfg now, so the callback will use that | 18:06 |
| dmsimard | We /could/ leverage that configuration "API" from Ansible (this is pretty much what ara 0.x does today) | 18:07 |
| apollo13 | I'll have to take a look at what ansible does | 18:07 |
| dmsimard | but that also makes it so we require ansible and I'm not sure I want to make the backend depend on ansible | 18:07 |
| apollo13 | anyways gotta run now; will think about it | 18:08 |
| dmsimard | alright | 18:08 |
| dmsimard | if you're good at database models, feel free to take a look at it too -- there are some particularities that I'd be happy to explain when you have time | 18:09 |
| *** tbielawa|lunch has quit IRC | 18:17 | |
| *** tbielawa has joined #ara | 18:26 | |
| *** Serienmorder has quit IRC | 18:40 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Expose the sha1 in the API file serializer https://review.openstack.org/607979 | 18:47 |
| openstackgerrit | Merged openstack/ara-plugins master: Update README.rst to be more accurate https://review.openstack.org/607281 | 18:57 |
| openstackgerrit | Merged openstack/ara-server master: Hash the files before compressing them https://review.openstack.org/607660 | 18:58 |
| *** tbielawa has quit IRC | 19:19 | |
| *** tbielawa has joined #ara | 19:28 | |
| *** tbielawa is now known as tbielawa|mtg | 19:34 | |
| *** tbielawa|mtg is now known as tbielawa | 20:36 | |
| *** tbielawa is now known as tbielawa|g0n3 | 21:46 | |
| *** tbielawa|g0n3 has quit IRC | 21:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!